Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc sonarlint changes #2297

Merged
merged 1 commit into from
Aug 1, 2022
Merged

misc sonarlint changes #2297

merged 1 commit into from
Aug 1, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jul 27, 2022

Mostly const changes.

Signed-off-by: Rosen Penev rosenp@gmail.com

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #2297 (2486a7d) into main (8ba9003) will increase coverage by 0.02%.
The diff coverage is 61.70%.

@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
+ Coverage   63.51%   63.53%   +0.02%     
==========================================
  Files         118      118              
  Lines       19610    19595      -15     
  Branches     9584     9576       -8     
==========================================
- Hits        12455    12450       -5     
+ Misses       5090     5079      -11     
- Partials     2065     2066       +1     
Impacted Files Coverage Δ
app/exiv2app.hpp 100.00% <ø> (ø)
include/exiv2/webpimage.hpp 100.00% <ø> (ø)
src/casiomn_int.cpp 6.89% <0.00%> (ø)
src/cr2image.cpp 19.73% <0.00%> (+0.25%) ⬆️
src/tiffcomposite_int.hpp 92.72% <ø> (ø)
src/tiffvisitor_int.hpp 100.00% <ø> (ø)
src/webpimage.cpp 43.14% <7.14%> (+0.47%) ⬆️
src/tiffimage_int.cpp 78.34% <25.00%> (+0.46%) ⬆️
src/tiffimage.cpp 70.54% <40.00%> (+1.60%) ⬆️
src/canonmn_int.cpp 71.55% <50.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ba9003...2486a7d. Read the comment docs.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes LGTM. I only have concerns about the comment I made.

src/tiffcomposite_int.cpp Outdated Show resolved Hide resolved
Mostly const changes.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb neheb merged commit 1d0530f into Exiv2:main Aug 1, 2022
@neheb neheb deleted the xnr branch August 1, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants