Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return make_unique directly #2289

Merged
merged 1 commit into from
Jul 25, 2022
Merged

return make_unique directly #2289

merged 1 commit into from
Jul 25, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jul 25, 2022

Simpler

Signed-off-by: Rosen Penev rosenp@gmail.com

@neheb neheb marked this pull request as ready for review July 25, 2022 02:08
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #2289 (ff737b5) into main (02b0ff3) will decrease coverage by 0.06%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
- Coverage   63.56%   63.50%   -0.07%     
==========================================
  Files         118      118              
  Lines       19601    19566      -35     
  Branches     9561     9540      -21     
==========================================
- Hits        12460    12425      -35     
  Misses       5077     5077              
  Partials     2064     2064              
Impacted Files Coverage Δ
src/exif.cpp 65.70% <66.66%> (-0.11%) ⬇️
app/actions.cpp 64.97% <77.77%> (-0.26%) ⬇️
src/crwimage_int.cpp 79.00% <100.00%> (-0.11%) ⬇️
src/tiffimage_int.cpp 77.77% <100.00%> (-0.13%) ⬇️
src/value.cpp 71.86% <100.00%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b0ff3...ff737b5. Read the comment docs.

@neheb
Copy link
Collaborator Author

neheb commented Jul 25, 2022

 /Users/runner/work/exiv2/exiv2/src/crwimage_int.cpp:248:15: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
    auto m = [this, pData, o, byteOrder]() -> std::unique_ptr<CiffComponent> {
              ^~~~~

Ummm that is bogus.

@neheb neheb force-pushed the uniq2 branch 2 times, most recently from ac3ac4a to b4ca3a5 Compare July 25, 2022 03:29
Simpler

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@neheb neheb merged commit 3ae1d3b into Exiv2:main Jul 25, 2022
@neheb neheb deleted the uniq2 branch July 25, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants