Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some sonarlint cleanups #2286

Merged
merged 7 commits into from
Jul 27, 2022
Merged

some sonarlint cleanups #2286

merged 7 commits into from
Jul 27, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jul 18, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 18, 2022 •
edited
Loading

Codecov Report

Merging #2286 (dd9fcb8) into main (4967964) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
- Coverage   63.53%   63.52%   -0.01%     
==========================================
  Files         118      118              
  Lines       19603    19603              
  Branches     9576     9577       +1     
==========================================
- Hits        12454    12453       -1     
- Misses       5085     5086       +1     
  Partials     2064     2064
Impacted Files Coverage Δ
src/basicio.cpp 51.38% <0.00%> (ø)
src/epsimage.cpp 1.74% <0.00%> (-0.01%) ⬇️
src/makernote_int.cpp 64.62% <0.00%> (ø)
src/tags_int.cpp 77.67% <0.00%> (ø)
src/value.cpp 71.86% <33.33%> (ø)
src/xmpsidecar.cpp 64.64% <66.66%> (-0.36%) ⬇️
src/properties.cpp 75.11% <71.42%> (ø)
app/actions.cpp 64.97% <100.00%> (ø)
app/exiv2app.hpp 100.00% <100.00%> (ø)
src/pngchunk_int.cpp 73.83% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4967964...dd9fcb8. Read the comment docs.

piponazo
piponazo previously approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@mergify mergify bot dismissed piponazo’s stale review July 20, 2022 20:46

Pull request has been modified.

@neheb
replace [0] with front() where applicable
7455464 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
sonarlint: replace lock_guard with scoped_lock
2f62cd8 
C++17 allows scoped_lock, which sonarlint recommends.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
sonarlint: replace loop with find_if
c12a266 
Sonarlint complains about this loop for some reason. Convert to find_if
to fix.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
sonarlint: add an empty do while loop
940a36b 
Avoids warnings regarding unnecessary semicolons.

Remove _fileno as it is unused.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
clang-tidy: use auto
fe702a2 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
clang-tidy: avoid C casts
9c175c0 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
replace shared_ptr with make_shared
dd9fcb8 
The former creates a nullptr. The latter actually allocates.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb neheb merged commit e34395e into Exiv2:main Jul 27, 2022
@neheb neheb deleted the xnr branch July 27, 2022 18:30
@nehaljwani nehaljwani mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piponazo piponazo piponazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neheb @piponazo