mostly clang-tidy fixes #2267
Merged
mostly clang-tidy fixes #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2267 +/- ##
==========================================
- Coverage 63.46% 63.45% -0.02%
==========================================
Files 118 118
Lines 19598 19589 -9
Branches 9556 9554 -2
==========================================
- Hits 12438 12430 -8
+ Misses 5094 5093 -1
Partials 2066 2066
Continue to review full report at Codecov.
|
Signed-off-by: Rosen Penev <rosenp@gmail.com>
It morphs into std::string anyway. Signed-off-by: Rosen Penev <rosenp@gmail.com>
No sense in passing by reference Signed-off-by: Rosen Penev <rosenp@gmail.com>
It doesn't do what it's supposed to here. Found with misc-misplaced-const Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Silences clang-tidy performance warning Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
kevinbackhouse
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.