Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some "signed shift" warnings #2266

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

kevinbackhouse
Copy link
Collaborator

Fix some "signed shift" warnings flagged by CodeQL. In all of the cases that I have fixed here, it makes more sense to use unsigned types.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #2266 (b3f2ab5) into main (08a68c3) will not change coverage.
The diff coverage is 78.78%.

@@           Coverage Diff           @@
##             main    #2266   +/-   ##
=======================================
  Coverage   63.47%   63.47%           
=======================================
  Files         118      118           
  Lines       19604    19604           
  Branches     9556     9556           
=======================================
  Hits        12444    12444           
  Misses       5094     5094           
  Partials     2066     2066           
Impacted Files Coverage Δ
include/exiv2/webpimage.hpp 100.00% <ø> (ø)
src/version.cpp 87.95% <0.00%> (ø)
src/webpimage.cpp 42.66% <28.57%> (ø)
src/types.cpp 94.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0e050...b3f2ab5. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit 60b3e28 into Exiv2:main Jul 5, 2022
@kevinbackhouse kevinbackhouse deleted the signed-shift branch July 5, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants