Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNG: always strip the existing iCCP chunk (backport #2254) #2256

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jul 1, 2022

Backports #2254

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #2256 (e79dc07) into 0.27-maintenance (0f1686f) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@                 Coverage Diff                  @@
##           0.27-maintenance    #2256      +/-   ##
====================================================
- Coverage             58.88%   58.88%   -0.01%     
====================================================
  Files                   149      149              
  Lines                 23208    23203       -5     
  Branches              12716    12711       -5     
====================================================
- Hits                  13666    13662       -4     
  Misses                 6702     6702              
+ Partials               2840     2839       -1     
Impacted Files Coverage Δ
src/pngimage.cpp 59.84% <50.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1686f...e79dc07. Read the comment docs.

@kmilos kmilos merged commit 575395f into 0.27-maintenance Jul 2, 2022
@kmilos
Copy link
Collaborator Author

kmilos commented Jul 2, 2022

Thanks!

@kmilos kmilos deleted the 027_fix_png_iccp branch July 2, 2022 10:45
@kmilos kmilos added bug imageHandler Anything related to specific ImageHandlers labels Jul 5, 2022
@kmilos kmilos added this to the v0.27.6 milestone Jul 5, 2022
@kmilos kmilos changed the title PNG: always strip the existing iCCP chunk PNG: always strip the existing iCCP chunk (backport #2254) Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug imageHandler Anything related to specific ImageHandlers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants