clang-tidy: use default member init

[neheb]

Signed-off-by: Rosen Penev rosenp@gmail.com

[codecov]

Codecov Report

Merging #2252 (bae7da1) into main (8a9f6ac) will decrease coverage by 0.01%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
- Coverage   63.46%   63.45%   -0.02%     
==========================================
  Files         118      118              
  Lines       19608    19602       -6     
  Branches     9562     9562              
==========================================
- Hits        12444    12438       -6     
  Misses       5096     5096              
  Partials     2068     2068              

Impacted Files	Coverage Δ
include/exiv2/basicio.hpp	91.66% <ø> (ø)
include/exiv2/image.hpp	100.00% <ø> (ø)
include/exiv2/tiffimage.hpp	100.00% <ø> (ø)
include/exiv2/value.hpp	84.44% <ø> (ø)
src/tiffcomposite_int.hpp	92.66% <ø> (ø)
src/tiffvisitor_int.hpp	100.00% <ø> (ø)
src/basicio.cpp	51.26% <50.00%> (-0.06%)	⬇️
src/image.cpp	69.57% <100.00%> (ø)
src/preview.cpp	46.63% <100.00%> (-0.12%)	⬇️
src/tiffcomposite_int.cpp	75.47% <100.00%> (-0.03%)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a9f6ac...bae7da1. Read the comment docs.

Pull request has been modified.

[piponazo]

PR looks good to me, although there is a clang-format issue.

[neheb]

I assume I'm using a newer version of clang-format that does not behave the same.

[neheb]

Yeah.

clang-format version 14.0.0 (Fedora 14.0.0-1.fc36)

results in

--- a/src/image_int.hpp
+++ b/src/image_int.hpp
@@ -65,7 +65,7 @@ struct binaryToStringHelper {
   explicit binaryToStringHelper(const Slice<T> myBuf) noexcept : buf_(myBuf) {
   }

-  friend std::ostream& operator<<<T>(std::ostream& stream, const binaryToStringHelper<T>& binToStr);
+  friend std::ostream& operator<< <T>(std::ostream& stream, const binaryToStringHelper<T>& binToStr);

   // the Slice is stored by value to avoid dangling references, in case we
   // invoke:

[neheb]

diff between 11 and 14 for google style.

colordiff 11 14
5,8c5,9
< AlignConsecutiveMacros: false
< AlignConsecutiveAssignments: false
< AlignConsecutiveBitFields: false
< AlignConsecutiveDeclarations: false
---
> AlignArrayOfStructures: None
> AlignConsecutiveMacros: None
> AlignConsecutiveAssignments: None
> AlignConsecutiveBitFields: None
> AlignConsecutiveDeclarations: None
13d13
< AllowAllConstructorInitializersOnNextLine: true
25a26,27
> AttributeMacros:
>   - __capability
47a50
> BreakBeforeConceptDeclarations: true
57a61
> QualifierAlignment: Leave
59d62
< ConstructorInitializerAllOnOneLineOrOnePerLine: true
65a69,70
> EmptyLineAfterAccessModifier: Never
> EmptyLineBeforeAccessModifier: LogicalBlock
66a72,75
> PackConstructorInitializers: NextLine
> BasedOnStyle:    ''
> ConstructorInitializerAllOnOneLineOrOnePerLine: false
> AllowAllConstructorInitializersOnNextLine: true
71a81,82
> IfMacros:
>   - KJ_IF_MAYBE
76a88
>     CaseSensitive:   false
79a92
>     CaseSensitive:   false
82a96
>     CaseSensitive:   false
85a100
>     CaseSensitive:   false
87a103
> IndentAccessModifiers: false
92a109
> IndentRequires:  false
98a116
> LambdaBodyIndentation: Signature
111a130
> PenaltyBreakOpenParenthesis: 0
115a135
> PenaltyIndentedWhitespace: 0
116a137
> PPIndentWidth:   -1
145c166
<     CanonicalDelimiter: ''
---
>     CanonicalDelimiter: pb
146a168
> ReferenceAlignment: Pointer
148c170,174
< SortIncludes:    true
---
> RemoveBracesLLVM: false
> SeparateDefinitionBlocks: Leave
> ShortNamespaceLines: 1
> SortIncludes:    CaseSensitive
> SortJavaStaticImport: Before
153a180
> SpaceBeforeCaseColon: false
157a185,193
> SpaceBeforeParensOptions:
>   AfterControlStatements: true
>   AfterForeachMacros: true
>   AfterFunctionDefinitionName: false
>   AfterFunctionDeclarationName: false
>   AfterIfMacros:   true
>   AfterOverloadedOperator: false
>   BeforeNonEmptyParentheses: false
> SpaceAroundPointerQualifiers: Default
162c198
< SpacesInAngles:  false
---
> SpacesInAngles:  Never
165a202,204
> SpacesInLineCommentPrefix:
>   Minimum:         1
>   Maximum:         -1
168a208
> BitFieldColonSpacing: Both
169a210,211
> StatementAttributeLikeMacros:
>   - Q_EMIT
179a222,223
>   - NS_SWIFT_NAME
>   - CF_SWIFT_NAME