Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix naming of canon EF 35-80mm. closes #2247 #2248

Merged
merged 2 commits into from
Jul 5, 2022
Merged

fix naming of canon EF 35-80mm. closes #2247 #2248

merged 2 commits into from
Jul 5, 2022

Conversation

hassec
Copy link
Member

@hassec hassec commented Jun 10, 2022

No description provided.

@hassec hassec added the lens Issue related to lens detection label Jun 10, 2022
@hassec hassec requested a review from piponazo June 10, 2022 14:43
@codecov
Copy link

codecov bot commented Jun 10, 2022 •
edited
Loading

Codecov Report

Merging #2248 (333c436) into main (7ebf2a1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2248   +/-   ##
=======================================
  Coverage   63.46%   63.46%           
=======================================
  Files         118      118           
  Lines       19612    19612           
  Branches     9566     9566           
=======================================
  Hits        12447    12447           
  Misses       5096     5096           
  Partials     2069     2069
Impacted Files Coverage Δ
src/canonmn_int.cpp 71.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ebf2a1...333c436. Read the comment docs.

@hassec hassec requested review from 1div0 and kmilos June 10, 2022 16:01
1div0
1div0 approved these changes Jun 12, 2022
View reviewed changes
Copy link
Collaborator

@1div0 1div0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

kmilos
kmilos approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please also backport the fix to 0.27-maintenance (can leave out the test I guess...)

@kevinbackhouse kevinbackhouse merged commit 5e4eab0 into main Jul 5, 2022
@kevinbackhouse
Copy link
Collaborator

@Mergifyio backport 0.27-maintenance

@mergify mergify bot mentioned this pull request Jul 5, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2022

backport 0.27-maintenance

✅ Backports have been created

@mergify mergify bot deleted the hassec_fix_2247 branch July 5, 2022 09:38
kmilos added a commit that referenced this pull request Aug 5, 2022
@kmilos
Merge pull request #2261 from Exiv2/mergify/bp/0.27-maintenance/pr-2248
aadb126 
fix naming of canon EF 35-80mm. closes #2247 (backport #2248)
@nehaljwani nehaljwani mentioned this pull request Apr 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1div0 1div0 1div0 approved these changes

@kmilos kmilos kmilos approved these changes

@piponazo piponazo Awaiting requested review from piponazo

Assignees
No one assigned
Labels
lens Issue related to lens detection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hassec @kevinbackhouse @1div0 @kmilos