Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy 14 fixes #2245

Merged
merged 3 commits into from
May 22, 2022
Merged

clang-tidy 14 fixes #2245

merged 3 commits into from
May 22, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented May 21, 2022

No description provided.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #2245 (a98954a) into main (93dc63b) will increase coverage by 0.00%.
The diff coverage is 55.00%.

❗ Current head a98954a differs from pull request most recent head cf963e9. Consider uploading reports for the commit cf963e9 to get more accurate results

@@           Coverage Diff           @@
##             main    #2245   +/-   ##
=======================================
  Coverage   63.42%   63.42%           
=======================================
  Files         117      118    +1     
  Lines       19592    19595    +3     
  Branches     9550     9549    -1     
=======================================
+ Hits        12426    12429    +3     
  Misses       5098     5098           
  Partials     2068     2068           
Impacted Files Coverage Δ
src/crwimage.cpp 70.51% <0.00%> (ø)
src/crwimage_int.hpp 93.02% <ø> (ø)
src/makernote_int.hpp 92.30% <ø> (ø)
src/pngchunk_int.cpp 74.12% <0.00%> (ø)
src/psdimage.cpp 52.25% <0.00%> (ø)
src/tiffvisitor_int.cpp 79.52% <0.00%> (ø)
src/value.cpp 72.78% <0.00%> (ø)
src/webpimage.cpp 43.42% <0.00%> (ø)
src/image.cpp 69.57% <50.00%> (ø)
src/jpgimage.cpp 67.80% <60.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93dc63b...cf963e9. Read the comment docs.

neheb added 2 commits May 21, 2022 17:39
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@piponazo piponazo merged commit 6e56ec1 into Exiv2:main May 22, 2022
@neheb neheb deleted the 2 branch May 22, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants