Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI jobs - Update conan packages #2240

Merged
merged 2 commits into from
May 19, 2022
Merged

Fix CI jobs - Update conan packages #2240

merged 2 commits into from
May 19, 2022

Conversation

piponazo
Copy link
Collaborator

@piponazo piponazo commented May 19, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #2240 (4e62ab5) into main (d59e143) will increase coverage by 0.12%.
The diff coverage is 81.55%.

❗ Current head 4e62ab5 differs from pull request most recent head 0309cb0. Consider uploading reports for the commit 0309cb0 to get more accurate results

@@            Coverage Diff             @@
##             main    #2240      +/-   ##
==========================================
+ Coverage   63.30%   63.42%   +0.12%     
==========================================
  Files         116      117       +1     
  Lines       19596    19592       -4     
  Branches     9544     9550       +6     
==========================================
+ Hits        12405    12426      +21     
+ Misses       5117     5098      -19     
+ Partials     2074     2068       -6     
Impacted Files Coverage Δ
include/exiv2/types.hpp 76.59% <ø> (ø)
include/exiv2/value.hpp 84.44% <ø> (ø)
src/basicio.cpp 51.32% <ø> (-0.13%) ⬇️
src/epsimage.cpp 1.73% <ø> (ø)
src/rafimage.cpp 20.52% <50.00%> (ø)
src/webpimage.cpp 43.42% <50.00%> (-1.18%) ⬇️
src/bmffimage.cpp 76.19% <64.70%> (+0.18%) ⬆️
src/pngimage.cpp 59.94% <77.27%> (+0.42%) ⬆️
app/actions.cpp 64.66% <83.33%> (-0.06%) ⬇️
src/types.cpp 94.47% <95.45%> (+8.00%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ed1df...0309cb0. Read the comment docs.

@piponazo piponazo marked this pull request as ready for review May 19, 2022 13:55
@piponazo piponazo requested review from hassec and kmilos May 19, 2022 13:55
kmilos
kmilos previously approved these changes May 19, 2022
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot dismissed kmilos’s stale review May 19, 2022 14:27

Pull request has been modified.

Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmilos
Copy link
Collaborator

kmilos commented May 19, 2022

Btw, we should also find a way to cancel running jobs if a new commit is pushed to the PR:

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-concurrency-to-cancel-any-in-progress-job-or-run

@piponazo piponazo merged commit 0594f86 into main May 19, 2022
@piponazo piponazo deleted the mainConanUpdate branch May 19, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants