Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for header bytes for Exif and XMP boxes (backport #2234) #2239

Merged
merged 1 commit into from
May 19, 2022
Merged

Account for header bytes for Exif and XMP boxes (backport #2234) #2239

merged 1 commit into from
May 19, 2022

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented May 19, 2022

No description provided.

@kmilos kmilos added the bug label May 19, 2022
@kmilos kmilos added this to the v0.27.6 milestone May 19, 2022
@kmilos kmilos added the imageHandler Anything related to specific ImageHandlers label May 19, 2022
piponazo
piponazo previously approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👏 . However, let's merge first #2241 so that we get all the CI jobs into green status before merging this branch

1div0
1div0 previously approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@1div0 1div0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@mergify mergify bot dismissed stale reviews from piponazo and 1div0 May 19, 2022 15:31

Pull request has been modified.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #2239 (847a5e8) into 0.27-maintenance (237d26b) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@                Coverage Diff                @@
##           0.27-maintenance    #2239   +/-   ##
=================================================
  Coverage             58.88%   58.88%           
=================================================
  Files                   149      149           
  Lines                 23209    23208    -1     
  Branches              12717    12716    -1     
=================================================
  Hits                  13666    13666           
  Misses                 6702     6702           
+ Partials               2841     2840    -1
Impacted Files Coverage Δ
src/bmffimage.cpp 76.58% <66.66%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237d26b...847a5e8. Read the comment docs.

@kmilos kmilos merged commit d6e39d6 into 0.27-maintenance May 19, 2022
@kmilos kmilos deleted the backport_2234 branch May 19, 2022 16:04
@nehaljwani nehaljwani mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piponazo piponazo piponazo approved these changes

@1div0 1div0 1div0 left review comments

@kevinbackhouse kevinbackhouse Awaiting requested review from kevinbackhouse

Assignees
No one assigned
Labels
bug imageHandler Anything related to specific ImageHandlers
Projects
None yet
Milestone
v0.27.6
Development

Successfully merging this pull request may close these issues.
3 participants
@kmilos @piponazo @1div0