Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some clang-tidy #2198

Merged
merged 5 commits into from
Apr 10, 2022
Merged

some clang-tidy #2198

merged 5 commits into from
Apr 10, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Apr 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #2198 (89b8d4e) into main (fdfcde5) will decrease coverage by 0.01%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##             main    #2198      +/-   ##
==========================================
- Coverage   63.32%   63.31%   -0.02%     
==========================================
  Files          99       99              
  Lines       19588    19586       -2     
  Branches     9555     9555              
==========================================
- Hits        12405    12401       -4     
- Misses       5112     5113       +1     
- Partials     2071     2072       +1     
Impacted Files Coverage Δ
src/http.cpp 0.00% <ø> (ø)
src/pngimage.cpp 59.51% <0.00%> (ø)
src/tiffimage_int.cpp 77.90% <ø> (ø)
src/version.cpp 87.95% <ø> (ø)
src/makernote_int.cpp 64.55% <60.00%> (-0.33%) ⬇️
src/jpgimage.cpp 71.98% <100.00%> (ø)
include/exiv2/types.hpp 76.59% <0.00%> (-2.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdfcde5...89b8d4e. Read the comment docs.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@piponazo piponazo merged commit 053f516 into Exiv2:main Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants