Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structured binding conversions #2195

Merged
merged 1 commit into from
Apr 9, 2022
Merged

structured binding conversions #2195

merged 1 commit into from
Apr 9, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Apr 7, 2022

Signed-off-by: Rosen Penev rosenp@gmail.com

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #2195 (2e8e0c6) into main (bd0eefd) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2195      +/-   ##
==========================================
- Coverage   63.34%   63.32%   -0.02%     
==========================================
  Files          99       99              
  Lines       19595    19588       -7     
  Branches     9560     9555       -5     
==========================================
- Hits        12412    12405       -7     
  Misses       5112     5112              
  Partials     2071     2071              
Impacted Files Coverage Δ
src/epsimage.cpp 1.73% <0.00%> (ø)
src/nikonmn_int.cpp 57.37% <48.00%> (ø)
src/olympusmn_int.cpp 38.38% <66.66%> (ø)
include/exiv2/value.hpp 84.37% <100.00%> (-0.14%) ⬇️
src/canonmn_int.cpp 71.55% <100.00%> (ø)
src/convert.cpp 51.40% <100.00%> (-0.08%) ⬇️
src/tiffcomposite_int.cpp 75.47% <100.00%> (ø)
src/types.cpp 86.47% <100.00%> (ø)
src/value.cpp 72.78% <100.00%> (ø)
src/version.cpp 87.95% <100.00%> (-0.15%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0eefd...2e8e0c6. Read the comment docs.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@piponazo piponazo merged commit fdfcde5 into Exiv2:main Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants