Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.27] Detect integer-overflow and throw in that case #2192

Merged
merged 2 commits into from
Apr 4, 2022
Merged

[0.27] Detect integer-overflow and throw in that case #2192

merged 2 commits into from
Apr 4, 2022

Conversation

piponazo
Copy link
Collaborator

@piponazo piponazo commented Apr 4, 2022

Fix #2190 in 0.27-maintenance

@piponazo piponazo added the bug label Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #2192 (f548681) into 0.27-maintenance (3403882) will not change coverage.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##           0.27-maintenance    #2192   +/-   ##
=================================================
  Coverage             58.87%   58.87%           
=================================================
  Files                   149      149           
  Lines                 23205    23205           
  Branches              12713    12713           
=================================================
  Hits                  13662    13662           
  Misses                 6702     6702           
  Partials               2841     2841
Impacted Files Coverage Δ
src/exif.cpp 66.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c39d5...f548681. Read the comment docs.

kmilos
kmilos approved these changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piponazo piponazo merged commit 3409ddd into 0.27-maintenance Apr 4, 2022
@piponazo piponazo deleted the 027_issue2190 branch April 4, 2022 11:05
@kmilos kmilos added this to the v0.27.6 milestone Jul 5, 2022
@nehaljwani nehaljwani mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmilos kmilos kmilos approved these changes

@kevinbackhouse kevinbackhouse Awaiting requested review from kevinbackhouse

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.27.6
Development

Successfully merging this pull request may close these issues.
2 participants
@piponazo @kmilos