Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.27 - Fix issue2178 #2186

Merged
merged 2 commits into from
Apr 1, 2022
Merged

0.27 - Fix issue2178 #2186

merged 2 commits into from
Apr 1, 2022

Conversation

piponazo
Copy link
Collaborator

@piponazo piponazo commented Apr 1, 2022

Backport of #2180 for 0.27-maintenance

@piponazo piponazo added this to the v0.27.6 milestone Apr 1, 2022
@piponazo piponazo marked this pull request as draft April 1, 2022 11:44
@piponazo
Copy link
Collaborator Author

piponazo commented Apr 1, 2022

Ups, there are many jobs failing on Linux. I'll fix those problems later today

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #2186 (3403882) into 0.27-maintenance (8c27e23) will increase coverage by 0.06%.
The diff coverage is 86.66%.

@@                 Coverage Diff                  @@
##           0.27-maintenance    #2186      +/-   ##
====================================================
+ Coverage             58.81%   58.87%   +0.06%     
====================================================
  Files                   148      149       +1     
  Lines                 23161    23205      +44     
  Branches              12696    12713      +17     
====================================================
+ Hits                  13621    13662      +41     
+ Misses                 6703     6702       -1     
- Partials               2837     2841       +4     
Impacted Files Coverage Δ
unitTests/test_jp2image_int.cpp 86.36% <86.36%> (ø)
src/jp2image_int.cpp 100.00% <100.00%> (+23.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c27e23...3403882. Read the comment docs.

@piponazo piponazo marked this pull request as ready for review April 1, 2022 13:25
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piponazo piponazo merged commit 51c39d5 into 0.27-maintenance Apr 1, 2022
@piponazo piponazo deleted the 027_issue2178 branch April 1, 2022 14:14
@kmilos kmilos added the bug label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants