Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key name to "Value not set" error message #2149

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Add key name to "Value not set" error message #2149

merged 2 commits into from
Mar 14, 2022

Conversation

jim-easterbrook
Copy link
Contributor

The error typically occurs when writeMetadata() is called. It's easier
to find the problem if you know which datum hasn't had a value set.

The error typically occurs when writeMetadata() is called. It's easier
to find the problem if you know which datum hasn't had a value set.
@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #2149 (04904db) into main (173ebb2) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2149   +/-   ##
=======================================
  Coverage   63.31%   63.31%           
=======================================
  Files          97       97           
  Lines       19152    19152           
  Branches     9724     9724           
=======================================
  Hits        12127    12127           
  Misses       4762     4762           
  Partials     2263     2263           
Impacted Files Coverage Δ
src/error.cpp 83.87% <ø> (ø)
src/exif.cpp 63.66% <0.00%> (ø)
src/iptc.cpp 66.10% <0.00%> (ø)
src/xmp.cpp 77.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173ebb2...04904db. Read the comment docs.

@piponazo
Copy link
Collaborator

Hi @jim-easterbrook , thanks for this contribution. I think the change you are proposing here makes sense.

Could you please rebase your branch in top of main ? We just merged some changes which slightly change the Error class.

@jim-easterbrook
Copy link
Contributor Author

Done, and still working OK.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@piponazo piponazo merged commit 04ae6c2 into Exiv2:main Mar 14, 2022
@jim-easterbrook jim-easterbrook deleted the mainAddKeyNameToValueNotSet branch March 14, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants