Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI actions #2143

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Update CI actions #2143

merged 1 commit into from
Mar 11, 2022

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Mar 11, 2022

Most updated to node16 as node 12 is going EOL in April

@kmilos kmilos requested a review from piponazo March 11, 2022 14:00
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #2143 (e7c55d1) into main (5c36c69) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2143   +/-   ##
=======================================
  Coverage   63.31%   63.31%           
=======================================
  Files          97       97           
  Lines       19127    19127           
  Branches     9713     9713           
=======================================
  Hits        12111    12111           
  Misses       4748     4748           
  Partials     2268     2268           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c36c69...e7c55d1. Read the comment docs.

@kmilos kmilos added the CI Issues related with CI jobs label Mar 11, 2022
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@kmilos kmilos merged commit 7aae68e into main Mar 11, 2022
@kmilos kmilos deleted the ci_actions_update branch March 11, 2022 14:46
@kmilos
Copy link
Collaborator Author

kmilos commented Mar 11, 2022

Thanks for the quick reviews!

@postscript-dev
Copy link
Collaborator

@kmilos:
I noticed that the Exiv2 nightly releases stopped being published after this PR was merged. The release workflow shows that there are problems in the Build Linux Release and Build Windows Release sections but the Build macOS Release works well.

I think that the changes made in this PR are justified but perhaps there is an unintended side-effect to them?

@kmilos
Copy link
Collaborator Author

kmilos commented May 30, 2022

No idea if these are indeed related. From the list, it doesn't look like those releases are/were regular/scheduled, and certainly not "nightly"...

@postscript-dev
Copy link
Collaborator

@kmilos:
Thanks for looking at this, GitHub actions are not my area of expertise. I suggested the link between the problems and the PR, only because the dates matched. The real cause could be something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues related with CI jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants