Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc cleanups #2132

Merged
merged 6 commits into from
Mar 8, 2022
Merged

misc cleanups #2132

merged 6 commits into from
Mar 8, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Mar 8, 2022

No description provided.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
include/exiv2/types.hpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #2132 (f252e3a) into main (7ed4303) will decrease coverage by 0.00%.
The diff coverage is 97.82%.

❗ Current head f252e3a differs from pull request most recent head c2bcd4b. Consider uploading reports for the commit c2bcd4b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2132      +/-   ##
==========================================
- Coverage   63.35%   63.35%   -0.01%     
==========================================
  Files          97       97              
  Lines       19175    19174       -1     
  Branches     9712     9712              
==========================================
- Hits        12149    12148       -1     
  Misses       4758     4758              
  Partials     2268     2268              
Impacted Files Coverage Δ
include/exiv2/types.hpp 72.22% <ø> (ø)
src/basicio.cpp 50.24% <ø> (ø)
src/pentaxmn_int.hpp 87.50% <ø> (ø)
src/tags_int.hpp 87.80% <ø> (ø)
src/tiffcomposite_int.hpp 87.87% <ø> (ø)
src/tiffimage_int.cpp 78.45% <ø> (ø)
src/types.cpp 86.26% <50.00%> (ø)
src/easyaccess.cpp 92.85% <100.00%> (ø)
src/nikonmn_int.cpp 58.73% <100.00%> (ø)
src/preview.cpp 47.12% <100.00%> (-0.12%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed4303...c2bcd4b. Read the comment docs.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@piponazo piponazo merged commit 89e66ff into Exiv2:main Mar 8, 2022
@neheb neheb deleted the 2 branch March 8, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants