Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversions to make_unique #2129

Merged
merged 1 commit into from
Mar 8, 2022
Merged

conversions to make_unique #2129

merged 1 commit into from
Mar 8, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Mar 6, 2022

Signed-off-by: Rosen Penev rosenp@gmail.com

@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #2129 (5ae294a) into main (7ed4303) will not change coverage.
The diff coverage is 16.66%.

❗ Current head 5ae294a differs from pull request most recent head b3823f4. Consider uploading reports for the commit b3823f4 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2129   +/-   ##
=======================================
  Coverage   63.35%   63.35%           
=======================================
  Files          97       97           
  Lines       19175    19175           
  Branches     9712     9712           
=======================================
  Hits        12149    12149           
  Misses       4758     4758           
  Partials     2268     2268           
Impacted Files Coverage Δ
src/tiffcomposite_int.hpp 87.87% <16.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed4303...b3823f4. Read the comment docs.

@neheb neheb force-pushed the 23 branch 2 times, most recently from 0b02e1f to 65cede8 Compare March 6, 2022 08:29
@piponazo
Copy link
Collaborator

piponazo commented Mar 7, 2022

I cannot explain why but I tried to run this locally and it is also failing on my Windows setup.

@neheb
Copy link
Collaborator Author

neheb commented Mar 7, 2022

seems to be some type problem. No clue.

@neheb neheb force-pushed the 23 branch 7 times, most recently from 7f3b696 to 31321cb Compare March 8, 2022 00:17
@neheb
Copy link
Collaborator Author

neheb commented Mar 8, 2022

Early speculation: the MSVC 7.1 bug comment might be a hint as to what's going wrong. I notice only one of the TiffBinaryArray functions uses it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy now 👍

@neheb
Copy link
Collaborator Author

neheb commented Mar 8, 2022

Yeah. TiffBinaryArray can be handled later.

@piponazo piponazo merged commit d8482b2 into Exiv2:main Mar 8, 2022
@neheb neheb deleted the 23 branch March 8, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants