Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some clang-tidy #2125

Merged
merged 9 commits into from
Mar 6, 2022
Merged

some clang-tidy #2125

merged 9 commits into from
Mar 6, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Mar 5, 2022

No description provided.

@neheb
manual braced init conversion
77e79b3 
clang-tidy's not converting these for some reason.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
clang-tidy: use emplace_back
e6d3315 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented Mar 5, 2022 •
edited
Loading

Codecov Report

Merging #2125 (def782f) into main (88b1c96) will decrease coverage by 0.01%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
- Coverage   63.38%   63.37%   -0.02%     
==========================================
  Files          97       97              
  Lines       19188    19185       -3     
  Branches     9714     9712       -2     
==========================================
- Hits        12163    12159       -4     
- Misses       4756     4757       +1     
  Partials     2269     2269
Impacted Files Coverage Δ
app/exiv2.cpp 59.46% <0.00%> (ø)
include/exiv2/basicio.hpp 100.00% <ø> (ø)
include/exiv2/datasets.hpp 100.00% <ø> (ø)
include/exiv2/error.hpp 65.51% <ø> (ø)
include/exiv2/exif.hpp 100.00% <ø> (ø)
include/exiv2/image.hpp 100.00% <ø> (ø)
include/exiv2/iptc.hpp 100.00% <ø> (ø)
include/exiv2/metadatum.hpp 72.72% <ø> (ø)
include/exiv2/properties.hpp 100.00% <ø> (ø)
include/exiv2/tags.hpp 100.00% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b1c96...def782f. Read the comment docs.

@neheb
manual nullptr conversions
5833101 
Mostly not caught because I'm not running clang-tidy on Windows.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
clang-tidy: use empty() instead of size()
6d1fa2e 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
clang-tidy: remove pointless get()
133849c 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
clang-tidy: simplify bool
63e41c3 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
clang-tidy: get rid of compare() usage
8cda090 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
clang-tidy: remove C casts
95355fe 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
replace several typedefs with using
def782f 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
piponazo
piponazo approved these changes Mar 6, 2022
View reviewed changes
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@piponazo piponazo merged commit 206514f into Exiv2:main Mar 6, 2022
@neheb neheb deleted the 1 branch March 6, 2022 07:51
@nehaljwani nehaljwani mentioned this pull request Apr 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piponazo piponazo piponazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neheb @piponazo