Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #2067

Merged
merged 91 commits into from
Feb 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
a459188
spelling: accelerometer
jsoref Feb 1, 2022
546b8ba
spelling: address
jsoref Feb 1, 2022
e70da19
spelling: anonymous
jsoref Feb 1, 2022
71a6f63
spelling: available
jsoref Feb 1, 2022
ee82cc9
spelling: baby
jsoref Feb 3, 2022
4f74b13
spelling: buffer
jsoref Feb 1, 2022
bcf51c0
spelling: build
jsoref Feb 1, 2022
8b0cf6d
spelling: builds
jsoref Feb 1, 2022
ffbacd4
spelling: by inclusion
jsoref Feb 1, 2022
2254d48
spelling: byte order
jsoref Feb 1, 2022
495a7f9
spelling: camera
jsoref Feb 1, 2022
1036dd9
spelling: command
jsoref Feb 2, 2022
1d53582
spelling: consistency
jsoref Feb 1, 2022
753e81a
spelling: constructor
jsoref Feb 1, 2022
eaa1d1e
spelling: continuous
jsoref Feb 1, 2022
abcba65
spelling: continuously
jsoref Feb 1, 2022
80bc713
spelling: correspond
jsoref Feb 1, 2022
4da19e6
spelling: decompression
jsoref Feb 2, 2022
99c4569
spelling: dedicated
jsoref Feb 1, 2022
0abb287
spelling: denominator
jsoref Feb 1, 2022
3e8dc2b
spelling: dependencies
jsoref Feb 1, 2022
4a78e7d
spelling: detector
jsoref Feb 1, 2022
59b9b20
spelling: dlighting
jsoref Feb 1, 2022
cd1292e
spelling: dragging
jsoref Feb 1, 2022
79d3c7d
spelling: duplicate
jsoref Feb 1, 2022
926b0c8
spelling: dynamic
jsoref Feb 1, 2022
1dd8f71
spelling: empty
jsoref Feb 1, 2022
ed18520
spelling: enable
jsoref Feb 1, 2022
5f8577f
spelling: endianness
jsoref Feb 1, 2022
cf7a35d
spelling: examining
jsoref Feb 1, 2022
3cc5ccb
spelling: exceed
jsoref Feb 1, 2022
649310b
spelling: extension
jsoref Feb 1, 2022
53a7cff
spelling: fact
jsoref Feb 1, 2022
9c0cb78
spelling: fails
jsoref Feb 1, 2022
c021ca7
spelling: fixed
jsoref Feb 2, 2022
fbdb448
spelling: fluorescent
jsoref Feb 1, 2022
b3f1490
spelling: focuspoint
jsoref Feb 1, 2022
e6f412b
spelling: focuspoints
jsoref Feb 4, 2022
1143e3d
spelling: from
jsoref Feb 2, 2022
9cc89f4
spelling: happened
jsoref Feb 1, 2022
98696d8
spelling: hierarchy
jsoref Feb 1, 2022
a7b3af2
spelling: initiate
jsoref Feb 1, 2022
b13bd76
spelling: interesting
jsoref Feb 1, 2022
9bbad82
spelling: internal
jsoref Feb 2, 2022
a9193ac
spelling: javascript
jsoref Feb 2, 2022
3f76968
spelling: language
jsoref Feb 1, 2022
f2dffaf
spelling: libiconv
jsoref Feb 1, 2022
38fb821
spelling: libraries
jsoref Feb 1, 2022
9e4681c
spelling: library
jsoref Feb 1, 2022
1e0783f
spelling: localization
jsoref Feb 2, 2022
602a8c0
spelling: macros
jsoref Feb 2, 2022
8316f60
spelling: member
jsoref Feb 2, 2022
fdfea71
spelling: members
jsoref Feb 2, 2022
e68c56d
spelling: metadata
jsoref Feb 1, 2022
6dd289a
spelling: miscellaneous
jsoref Feb 1, 2022
41539cb
spelling: mnemonic
jsoref Feb 1, 2022
4bb7953
spelling: modified
jsoref Feb 1, 2022
8064444
spelling: multiple
jsoref Feb 1, 2022
0441b2b
spelling: multithreaded
jsoref Feb 1, 2022
f7bce78
spelling: mysterious
jsoref Feb 1, 2022
a6f9d5c
spelling: photoshop
jsoref Feb 1, 2022
8c83bca
spelling: platforms
jsoref Feb 1, 2022
8dc80fd
spelling: preliminary
jsoref Feb 1, 2022
ec0d7c9
spelling: priority
jsoref Feb 1, 2022
3fcd33b
spelling: properties
jsoref Feb 1, 2022
d253798
spelling: qualifier
jsoref Feb 1, 2022
dd04fd8
spelling: recognition
jsoref Feb 1, 2022
f33d096
spelling: recognized
jsoref Feb 1, 2022
c2b8943
spelling: reentrancy
jsoref Feb 1, 2022
60d4afa
spelling: remaining
jsoref Feb 1, 2022
fdc5414
spelling: remotetest
jsoref Feb 2, 2022
f50bed4
spelling: requested
jsoref Feb 1, 2022
d5ae5b9
spelling: sensitivity
jsoref Feb 1, 2022
2770f07
spelling: standardize
jsoref Feb 1, 2022
b9c9330
spelling: successful
jsoref Feb 1, 2022
85a420b
spelling: such
jsoref Feb 2, 2022
32f7a3a
spelling: tags
jsoref Feb 2, 2022
b7c1584
spelling: temperature
jsoref Feb 2, 2022
cae7bc7
spelling: test
jsoref Feb 2, 2022
66a7604
spelling: the
jsoref Feb 2, 2022
24669e1
spelling: these
jsoref Feb 2, 2022
ccb7bb0
spelling: third
jsoref Feb 1, 2022
a7fd380
spelling: this
jsoref Feb 2, 2022
75498f4
spelling: transparent
jsoref Feb 1, 2022
8f29503
spelling: unable
jsoref Feb 2, 2022
e566bce
spelling: underwater
jsoref Feb 1, 2022
a41af26
spelling: uninterpreted
jsoref Feb 1, 2022
7c783f6
spelling: using
jsoref Feb 2, 2022
d32e19b
spelling: utc - coordinated universal time
jsoref Feb 2, 2022
c93f190
spelling: which
jsoref Feb 2, 2022
709082e
spelling: with
jsoref Feb 2, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODING_GUIDELINES.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Coding Guidelines
- All new code that is added must be resistant to integer overflows, thus if you multiply, add, subtract, divide or bitshift integers you must ensure that no overflow can occur. Please keep in mind that signed integer overflow is undefined behavior, thus you must check for overflows before performing the arithmetic operation, otherwise the compiler is free to optimize your check after the overflow away (this has happened already).
- All new code must be resistant to buffer overflows. Thus before you access arrays a range check must be performed.
- Distrust any data that you extract from images or from external sources. E.g. if the metadata of an image gives you an offset of another information inside that file, do not assume that this offset will not result in an out off bounds read.
- New code must not assume the endianes and the word size of the system it is being run on. I.e. don't assume that `sizeof(int) = 8` or that the following will work:
- New code must not assume the endianness and the word size of the system it is being run on. I.e. don't assume that `sizeof(int) = 8` or that the following will work:
```cpp
const uint32_t some_var = get_var();
const uint16_t lower_2_bytes = (const uint16_t*) &some_var;
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Once you have a GitHub login:
$ git fetch exiv2_upstream master
$ git checkout -b my-new-feature exiv2_upstream/master --no-track

NB: This is an important step to avoid draging in old commits!
NB: This is an important step to avoid dragging in old commits!

5. Configure the project and check that it builds (if not, please report a bug):

Expand Down
2 changes: 1 addition & 1 deletion GIT_GUIDELINES.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ A commit message can look like this:
- Specify concrete ubuntu and mac versions
- Use latest conan version
- Fix the profiles for linux and mac
- Use new version of expat (avilable in conan-center)
- Use new version of expat (available in conan-center)
- Install urllib3 as suggested in python guidelines
- Use virtualenv with python3
```
Expand Down
8 changes: 4 additions & 4 deletions README-SAMPLES.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ The following programs are build and installed in /usr/local/bin.
| _**addmoddel**_ | Demonstrates Exiv2 library APIs to add, modify or delete metadata | [addmoddel](#addmoddel) | [addmoddel.cpp](samples/addmoddel.cpp) |
| _**exifcomment**_ | Set Exif.Photo.UserComment in an image | [exifcomment](#exifcomment) | [exifcomment.cpp](samples/exifcomment.cpp) |
| _**exifdata**_ | Prints _**Exif**_ metadata in different formats in an image | [exifdata](#exifdata) | [exifdata.cpp](samples/exifdata.cpp) |
| _**exifprint**_ | Print _**Exif**_ metadata in images<br>Miscelleous other features | [exifprint](#exifprint)| [exifprint.cpp](samples/exifprint.cpp) |
| _**exifprint**_ | Print _**Exif**_ metadata in images<br>Miscellaneous other features | [exifprint](#exifprint)| [exifprint.cpp](samples/exifprint.cpp) |
| _**exifvalue**_ | Prints the value of a single _**Exif**_ tag in a file | [exifvalue](#exifvalue) | [exifvalue.cpp](samples/exifvalue.cpp) |
| _**exiv2**_ | Utility to read and write image metadata, including Exif, IPTC, XMP, image comments, ICC Profile, thumbnails, image previews and many vendor makernote tags.<br>This is the primary test tool used by Team Exiv2 and can exercise almost all code in the library. Due to the extensive capability of this utility, the APIs used are usually less obvious for casual code inspection. | [exiv2 manpage](exiv2.md)<br>[https://exiv2.org/sample.html](https://exiv2.org/sample.html) | |
| _**exiv2json**_ | Extracts data from image in JSON format.<br>This program also contains a parser to recursively parse Xmp metadata into vectors and objects. | [exiv2json](#exiv2json) | [exiv2json.cpp](samples/exiv2json.cpp) |
Expand Down Expand Up @@ -162,7 +162,7 @@ Option: all | exif | iptc | xmp | filesystem

This program dumps metadata from an image in JSON format. _Code: [exiv2json.cpp](samples/exiv2json.cpp)_

exiv2json has a recursive parser to encode XMP into Vectors and Objects. XMP data is XMP and can contain XMP `Bag` and `Seq` which are converted to JSON Objects and Arrays. Exiv2 presents data in the format: [Family.Group.Tagname](exiv2.md#exiv2_key_syntax). For XMP, results in "flat" output such such as:
exiv2json has a recursive parser to encode XMP into Vectors and Objects. XMP data is XMP and can contain XMP `Bag` and `Seq` which are converted to JSON Objects and Arrays. Exiv2 presents data in the format: [Family.Group.Tagname](exiv2.md#exiv2_key_syntax). For XMP, results in "flat" output such as:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally my PRs only look at individual words, but I've been toying with this related task of identifying duplicated words. This repository was good input for my tool.

If feedback on this feature is negative, I may drop it going forward.

For simplicity, I've tagged these commits with the word that was duplicated, although, I might change my commit messages based on feedback.


```
$ curl --silent -O https://clanmills.com/Stonehenge.jpg
Expand Down Expand Up @@ -211,7 +211,7 @@ $
Usage: geotag {-help|-version|-dst|-dryrun|-ascii|-verbose|-adjust value|-tz value|-delta value}+ path+
```

Geotag reads one or more GPX files and adds GPS Tages to images. _Code: [geotag.cpp](samples/geotag.cpp)_
Geotag reads one or more GPX files and adds GPS Tags to images. _Code: [geotag.cpp](samples/geotag.cpp)_

If the path is a directory, geotag will read all the files in the directory. It constructs a time dictionary of position data, then updates every image with GPS Tags.

Expand Down Expand Up @@ -478,7 +478,7 @@ Test access to preview images
#### remotetest

```
Usage: remotetest remotetest file {--nocurl | --curl}
Usage: remotetest file {--nocurl | --curl}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any indication for this duplication...

```

Tester application for testing remote i/o.
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

| **CI Status:** | | |
|:-- |:-- |:-- |
| [![Basic CI for all platforms on push](https://github.com/Exiv2/exiv2/actions/workflows/on_push_BasicWinLinMac.yml/badge.svg?branch=main)](https://github.com/Exiv2/exiv2/actions/workflows/on_push_BasicWinLinMac.yml) | [![CI for different Linux distributions](https://github.com/Exiv2/exiv2/actions/workflows/nightly_Linux_distributions.yml/badge.svg?branch=main)](https://github.com/Exiv2/exiv2/actions/workflows/nightly_Linux_distributions.yml) | [![Linux Special Builds on PRs](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_special_buils.yml/badge.svg)](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_special_buils.yml) |
| [![Basic CI for all platforms on push](https://github.com/Exiv2/exiv2/actions/workflows/on_push_BasicWinLinMac.yml/badge.svg?branch=main)](https://github.com/Exiv2/exiv2/actions/workflows/on_push_BasicWinLinMac.yml) | [![CI for different Linux distributions](https://github.com/Exiv2/exiv2/actions/workflows/nightly_Linux_distributions.yml/badge.svg?branch=main)](https://github.com/Exiv2/exiv2/actions/workflows/nightly_Linux_distributions.yml) | [![Linux Special Builds on PRs](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_special_builds.yml/badge.svg)](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_special_builds.yml) |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is renamed above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but note this will lead to a completely new workflow created here (with the same name though), and the old runs will have to be deleted via the API.

| [![Linux-Ubuntu Matrix on PRs](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_matrix.yml/badge.svg)](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_matrix.yml) | [![Mac Matrix on PRs](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_mac_matrix.yml/badge.svg)](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_mac_matrix.yml) | [![Win Matrix on PRs](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_windows_matrix.yml/badge.svg)](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_windows_matrix.yml) |

<div id="1">
Expand Down Expand Up @@ -197,7 +197,7 @@ CMake will detect libiconv of all UNIX like systems including Linux, macOS, UNIX

The library libiconv is a GNU library and we do not recommend using libiconv with Exiv2 when building with Visual Studio.

Exiv2 includes the file cmake/FindIconv.cmake which contains a guard to prevent CMake from finding libiconv when you build with Visual Studio. This was added because of issues reported when Visual Studio attempted to link libconv libraries installed by Cygwin, or MinGW or gnuwin32. [https://github.com/Exiv2/exiv2/issues/1250](https://github.com/Exiv2/exiv2/issues/1250)
Exiv2 includes the file cmake/FindIconv.cmake which contains a guard to prevent CMake from finding libiconv when you build with Visual Studio. This was added because of issues reported when Visual Studio attempted to link libiconv libraries installed by Cygwin, or MinGW or gnuwin32. [https://github.com/Exiv2/exiv2/issues/1250](https://github.com/Exiv2/exiv2/issues/1250)

There are build instructions about Visual Studio in libiconv-1.16/INSTALL.window require you to install Cygwin. There is an article here about building libiconv with Visual Studio. [https://www.codeproject.com/Articles/302012/How-to-Build-libiconv-with-Microsoft-Visual-Studio](https://www.codeproject.com/Articles/302012/How-to-Build-libiconv-with-Microsoft-Visual-Studio).

Expand Down Expand Up @@ -654,7 +654,7 @@ You can cross compile Exiv2 on Linux for MinGW. We have used the following meth
$ sudo dnf install mingw64-gcc-c++ mingw64-filesystem mingw64-expat mingw64-zlib cmake make
```

#### 2 Install Dependancies
#### 2 Install Dependencies

You will need to install x86_64 libraries to support the options you wish to use. By default, you will need libz and expat. Your `dnf` command above has installed them for you. If you wish to use features such as `webready` you should install openssl and libcurl as follows:

Expand Down Expand Up @@ -807,7 +807,7 @@ Access to the bmff code is guarded in two ways. Firstly, you have to build the
EXIV2API bool enableBMFF(bool enable);
```

The return value from `enableBMFF()` is true if the library has been build with bmff support (cmake option -DEXIV2_ANABLE_BMFF=On).
The return value from `enableBMFF()` is true if the library has been build with bmff support (cmake option -DEXIV2_ENABLE_BMFF=On).

Applications may wish to provide a preference setting to enable bmff support and thereby place the responsibility for the use of this code with the user of the application.

Expand Down
2 changes: 1 addition & 1 deletion SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Team Exiv2 does not back-port security (or any other fix) to earlier releases of

The version numbering scheme is explained below. The design includes provision for a security release. A _**Dot Release**_ is an updated version of the library with security PRs and other changes. A _**Dot Release**_ offers the same API as its parent. A _**Security Release**_ is an existing release PLUS one or more security PRs. Nothing else is changed from it parent.

Users can register on github.com to receive release notices for RC and GM Releases. Additionally, we inform users when we begin a project to create a new release on FaceBook (https://facebook.com/exiv2) and Discuss Pixls (https://discuss.pixls.us). The announcement of a new release project has a preliminay specification and schedule.
Users can register on github.com to receive release notices for RC and GM Releases. Additionally, we inform users when we begin a project to create a new release on FaceBook (https://facebook.com/exiv2) and Discuss Pixls (https://discuss.pixls.us). The announcement of a new release project has a preliminary specification and schedule.

## Version Numbering Scheme

Expand Down
10 changes: 5 additions & 5 deletions cmake/Doxyfile.in
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ OPTIMIZE_OUTPUT_VHDL = NO
# parses. With this tag you can assign which parser to use for a given
# extension. Doxygen has a built-in mapping, but you can override or extend it
# using this tag. The format is ext=language, where ext is a file extension, and
# language is one of the parsers supported by doxygen: IDL, Java, Javascript,
# language is one of the parsers supported by doxygen: IDL, Java, JavaScript,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to drop files/exclude paths, just let me know what should be skipped.

JavaScript is a brand... (catching this actually relied on the same extra tooling as catching duplicate words)

# C#, C, C++, D, PHP, Objective-C, Python, Fortran (fixed format Fortran:
# FortranFixed, free formatted Fortran: FortranFree, unknown formatted Fortran:
# Fortran. In the later case the parser tries to guess whether the code is fixed
Expand Down Expand Up @@ -675,7 +675,7 @@ SHOW_NAMESPACES = YES
# The FILE_VERSION_FILTER tag can be used to specify a program or script that
# doxygen should invoke to get the current version for each file (typically from
# the version control system). Doxygen will invoke the program by executing (via
# popen()) the command command input-file, where command is the value of the
# popen()) the command input-file, where command is the value of the
# FILE_VERSION_FILTER tag, and input-file is the name of an input file provided
# by doxygen. Whatever the program writes to standard output is used as the file
# version. For an example see the documentation.
Expand Down Expand Up @@ -1474,7 +1474,7 @@ EXT_LINKS_IN_WINDOW = NO

FORMULA_FONTSIZE = 10

# Use the FORMULA_TRANPARENT tag to determine whether or not the images
# Use the FORMULA_TRANSPARENT tag to determine whether or not the images
# generated for formulas are transparent PNGs. Transparent PNGs are not
# supported properly for IE 6.0, but are supported on all modern browsers.
#
Expand All @@ -1486,7 +1486,7 @@ FORMULA_FONTSIZE = 10
FORMULA_TRANSPARENT = YES

# Enable the USE_MATHJAX option to render LaTeX formulas using MathJax (see
# http://www.mathjax.org) which uses client side Javascript for the rendering
# http://www.mathjax.org) which uses client side JavaScript for the rendering
# instead of using pre-rendered bitmaps. Use this if you do not have LaTeX
# installed or if you want to formulas look prettier in the HTML output. When
# enabled you may also need to install MathJax separately and configure the path
Expand Down Expand Up @@ -1556,7 +1556,7 @@ MATHJAX_CODEFILE =
SEARCHENGINE = YES

# When the SERVER_BASED_SEARCH tag is enabled the search engine will be
# implemented using a web server instead of a web client using Javascript. There
# implemented using a web server instead of a web client using JavaScript. There
# are two flavors of web server based searching depending on the EXTERNAL_SEARCH
# setting. When disabled, doxygen will generate a PHP script for searching and
# an index file used by the script. When EXTERNAL_SEARCH is enabled the indexing
Expand Down
2 changes: 1 addition & 1 deletion cmake/JoinPaths.cmake
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This module provides function for joining paths
# known from from most languages
# known from most languages
Comment on lines 1 to +2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changes are for spelling (duplicate words are often detected by classic spell checkers) and don't cover grammar. In this case, even w/ this fix, the text doesn't make much sense.

#
# Original license:
# SPDX-License-Identifier: (MIT OR CC0-1.0)
Expand Down
2 changes: 1 addition & 1 deletion cmake/packaging.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ foreach(doc ${DOCS})
install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/${doc} DESTINATION .)
endforeach()

# copy build/log which which is present if built by build.sh
# copy build/log which is present if built by build.sh
if(EXISTS ${PROJECT_SOURCE_DIR}/build/logs/build.txt)
install(FILES ${PROJECT_SOURCE_DIR}/build/logs/build.txt DESTINATION "logs")
endif()
Expand Down
2 changes: 1 addition & 1 deletion contrib/coverity.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#
# Before to run this script you must set these shell variable :
# $EXIVCoverityToken with token of Exiv2 project given by Coverity SCAN
# $EXIVCoverityEmail with email adress to send SCAN result.
# $EXIVCoverityEmail with email address to send SCAN result.
#
# Coverity Scan bin dir must be appended to PATH variable.
#
Expand Down
2 changes: 1 addition & 1 deletion contrib/vs2019/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ E:\Projects\libexpat. The exiv2 solution will have the exiv2 project
exposition) and the expat-static project (from libexpat). The
expat-static project is added as a reference to the exiv2
project. This make Visual Studio generate the correct dependency
heirarchy and compile correctly.
hierarchy and compile correctly.

# Folder Structure #

Expand Down
20 changes: 10 additions & 10 deletions doc/ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ Build: (11)
0001329 Error during cmake with gcc version parsing
0001310 Provide support for msys/2.0
0001299 exiv2-0.26-trunk.tar.gz changed on download server
0001270 Using libexiv2.a/.lib in multhreaded app segfaults.
0001270 Using libexiv2.a/.lib in multithreaded app segfaults.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects don't like fixing changelogs. Happy to drop if that's the case.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine for me to fix typos in the changlog too 👍

0001237 Report CMake/MinGW issues to Kitware
0001188 Provide build support for C++11
0001174 Visual Studio Support Enhancements
Expand Down Expand Up @@ -643,9 +643,9 @@ Changes from version 0.25 to 0.26
- 0001145: Respect Sony/Minolta lenses with shared LensID such as Tamron SP AF 17-50mm F2.8 XR Di II LD
- 0001144: Sigma 10-20mm f/4-5.6 EX DC is detected as Tamaron
(Simon Harhues)
- 0001142: Manual lens does not get recogniced: Beroflex zoom 500mm
- 0001142: Manual lens does not get recognized: Beroflex zoom 500mm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project has a lot of en-GB. My default is en-US, so the corrections here are en-US. Happy to switch if there's a strong preference.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would wait for @clanmills feedback on this matter. He has been the main maintainer of the project for many years, and I am sure he will have something to say about this 😸.

I do not have a strong preference for one or another.

(Simon Harhues / Niels Kristian Bech Jensen)
- 0001141: Manual lens does not get recogniced: Pentax macro 100mm
- 0001141: Manual lens does not get recognized: Pentax macro 100mm
(Simon Harhues / Niels Kristian Bech Jensen)
- 0001118: Add support for ZEISS Loxia 2/50 lens
(Eugen Neu)
Expand Down Expand Up @@ -689,7 +689,7 @@ Changes from version 0.25 to 0.26
- 0000922: Add options -pS and -dI to application exiv2
- 0000855: Segfault when accessing focalLength with 0.23
(Tobias E.)
- 0000756: Access to ICC Profile (TAG: 0x8773) data in Exif as uninterpretted binary
- 0000756: Access to ICC Profile (TAG: 0x8773) data in Exif as uninterpreted binary
(Ray NA)
- 0000676: Patch for reading ICC color profiles
(Andreas Huggel)
Expand Down Expand Up @@ -783,7 +783,7 @@ Changes from version 0.25 to 0.26

* Testing: (6)
- 0001230: Bug Hunt for v0.26
- 0001207: digiKam maintenance tool to synchronize files metadata and database crash in Exiv2 (re-entrancy issue ?)
- 0001207: digiKam maintenance tool to synchronize files metadata and database crash in Exiv2 (reentrancy issue ?)
(Uwe Haider)
- 0001057: Implement target/modifier - (stdin/stdout) for exiv2 options -i (insert) and -e (extract)
- 0001045: Add COPYRIGHT file to test/data/
Expand Down Expand Up @@ -1192,7 +1192,7 @@ Changes from version 0.23 to 0.24
(Reported by S. Verdoold, patch by Pascal de Bruijn)
- 0000861: Sigma 18-250mm not properly recognised on Pentax
(Reported by S. Verdoold, patch by Pascal de Bruijn)
- 0000862: Video code is failing the test suite (on all plaforms)
- 0000862: Video code is failing the test suite (on all platforms)
(Robin Mills, Abhinav Badola)
- 0000865: Patches for locale and boost issue (Patches by Mario anyc)
- 0000868: Support for two lens for sony mount
Expand Down Expand Up @@ -1463,7 +1463,7 @@ Changes from version 0.20 to 0.21
(Patch by Matthias Baas)
- Added ExifKey::defaultCount() to access the new count reference
information.
- Fixed zlib uncompression of large PNG metadata buffers.
- Fixed zlib decompression of large PNG metadata buffers.
- Improved determination of MIME type.
- Updated Canon makernote. (Greg Mansfield, Axel Waggershauser)
- Updated Olympus makernote. (Greg Mansfield)
Expand Down Expand Up @@ -1713,7 +1713,7 @@ Changes from version 0.18 to 0.18.1
support for multiple TIFF tree structures.

* MSVC related
- 0000621: windows librarys are forcing a link to
- 0000621: windows libraries are forcing a link to
..\..\..\zlib-1.2.3\projects\visual6\blah\blah.
(Reported by Peter J. Ersts, fix by Robin Mills)

Expand Down Expand Up @@ -2051,7 +2051,7 @@ Changes from version 0.12 to 0.13
and insert actions.

* Exiv2 library
- 0000503: [metadata] Tiff generated by photoshop crashes exiv2
- 0000503: [metadata] Tiff generated by Photoshop crashes exiv2
(digikam bug 139658).
- 0000502: [iptc] New TIFF parser: Decode IPTC from Exif.Image.IPTCNAA.
(Reported by Walter Hangartner)
Expand Down Expand Up @@ -2124,7 +2124,7 @@ Changes from version 0.11 to 0.12
- [exif] Updated Minolta makernote. (Gilles Caulier, Paul Tribick)

* MSVC related
- 0000487: Crash in exiv2.exe (built with VC++ 2005 Express) when examing TIFF
- 0000487: Crash in exiv2.exe (built with VC++ 2005 Express) when examining TIFF
images (Reported with patch by Dimitri Schoolwerth)


Expand Down
2 changes: 1 addition & 1 deletion doc/cmdxmp.txt
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ set Xmp.xmpDM.videoFrameSize/stDim:unit inch
set Xmp.dc.publisher James Bond
set Xmp.dc.publisher[1]/?ns:role secret agent

# Add a qualifer to an array element of Xmp.dc.creator (added above)
# Add a qualifier to an array element of Xmp.dc.creator (added above)
set Xmp.dc.creator[2]/?ns:role programmer

# Add an array of structures. First set a text property with just the
Expand Down
Loading