-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #2067
Spelling #2067
Changes from all commits
a459188
546b8ba
e70da19
71a6f63
ee82cc9
4f74b13
bcf51c0
8b0cf6d
ffbacd4
2254d48
495a7f9
1036dd9
1d53582
753e81a
eaa1d1e
abcba65
80bc713
4da19e6
99c4569
0abb287
3e8dc2b
4a78e7d
59b9b20
cd1292e
79d3c7d
926b0c8
1dd8f71
ed18520
5f8577f
cf7a35d
3cc5ccb
649310b
53a7cff
9c0cb78
c021ca7
fbdb448
b3f1490
e6f412b
1143e3d
9cc89f4
98696d8
a7b3af2
b13bd76
9bbad82
a9193ac
3f76968
f2dffaf
38fb821
9e4681c
1e0783f
602a8c0
8316f60
fdfea71
e68c56d
6dd289a
41539cb
4bb7953
8064444
0441b2b
f7bce78
a6f9d5c
8c83bca
8dc80fd
ec0d7c9
3fcd33b
d253798
dd04fd8
f33d096
c2b8943
60d4afa
fdc5414
f50bed4
d5ae5b9
2770f07
b9c9330
85a420b
32f7a3a
b7c1584
cae7bc7
66a7604
24669e1
ccb7bb0
a7fd380
75498f4
8f29503
e566bce
a41af26
7c783f6
d32e19b
c93f190
709082e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,7 @@ The following programs are build and installed in /usr/local/bin. | |
| _**addmoddel**_ | Demonstrates Exiv2 library APIs to add, modify or delete metadata | [addmoddel](#addmoddel) | [addmoddel.cpp](samples/addmoddel.cpp) | | ||
| _**exifcomment**_ | Set Exif.Photo.UserComment in an image | [exifcomment](#exifcomment) | [exifcomment.cpp](samples/exifcomment.cpp) | | ||
| _**exifdata**_ | Prints _**Exif**_ metadata in different formats in an image | [exifdata](#exifdata) | [exifdata.cpp](samples/exifdata.cpp) | | ||
| _**exifprint**_ | Print _**Exif**_ metadata in images<br>Miscelleous other features | [exifprint](#exifprint)| [exifprint.cpp](samples/exifprint.cpp) | | ||
| _**exifprint**_ | Print _**Exif**_ metadata in images<br>Miscellaneous other features | [exifprint](#exifprint)| [exifprint.cpp](samples/exifprint.cpp) | | ||
| _**exifvalue**_ | Prints the value of a single _**Exif**_ tag in a file | [exifvalue](#exifvalue) | [exifvalue.cpp](samples/exifvalue.cpp) | | ||
| _**exiv2**_ | Utility to read and write image metadata, including Exif, IPTC, XMP, image comments, ICC Profile, thumbnails, image previews and many vendor makernote tags.<br>This is the primary test tool used by Team Exiv2 and can exercise almost all code in the library. Due to the extensive capability of this utility, the APIs used are usually less obvious for casual code inspection. | [exiv2 manpage](exiv2.md)<br>[https://exiv2.org/sample.html](https://exiv2.org/sample.html) | | | ||
| _**exiv2json**_ | Extracts data from image in JSON format.<br>This program also contains a parser to recursively parse Xmp metadata into vectors and objects. | [exiv2json](#exiv2json) | [exiv2json.cpp](samples/exiv2json.cpp) | | ||
|
@@ -162,7 +162,7 @@ Option: all | exif | iptc | xmp | filesystem | |
|
||
This program dumps metadata from an image in JSON format. _Code: [exiv2json.cpp](samples/exiv2json.cpp)_ | ||
|
||
exiv2json has a recursive parser to encode XMP into Vectors and Objects. XMP data is XMP and can contain XMP `Bag` and `Seq` which are converted to JSON Objects and Arrays. Exiv2 presents data in the format: [Family.Group.Tagname](exiv2.md#exiv2_key_syntax). For XMP, results in "flat" output such such as: | ||
exiv2json has a recursive parser to encode XMP into Vectors and Objects. XMP data is XMP and can contain XMP `Bag` and `Seq` which are converted to JSON Objects and Arrays. Exiv2 presents data in the format: [Family.Group.Tagname](exiv2.md#exiv2_key_syntax). For XMP, results in "flat" output such as: | ||
|
||
``` | ||
$ curl --silent -O https://clanmills.com/Stonehenge.jpg | ||
|
@@ -211,7 +211,7 @@ $ | |
Usage: geotag {-help|-version|-dst|-dryrun|-ascii|-verbose|-adjust value|-tz value|-delta value}+ path+ | ||
``` | ||
|
||
Geotag reads one or more GPX files and adds GPS Tages to images. _Code: [geotag.cpp](samples/geotag.cpp)_ | ||
Geotag reads one or more GPX files and adds GPS Tags to images. _Code: [geotag.cpp](samples/geotag.cpp)_ | ||
|
||
If the path is a directory, geotag will read all the files in the directory. It constructs a time dictionary of position data, then updates every image with GPS Tags. | ||
|
||
|
@@ -478,7 +478,7 @@ Test access to preview images | |
#### remotetest | ||
|
||
``` | ||
Usage: remotetest remotetest file {--nocurl | --curl} | ||
Usage: remotetest file {--nocurl | --curl} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't see any indication for this duplication... |
||
``` | ||
|
||
Tester application for testing remote i/o. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
|
||
| **CI Status:** | | | | ||
|:-- |:-- |:-- | | ||
| [![Basic CI for all platforms on push](https://github.com/Exiv2/exiv2/actions/workflows/on_push_BasicWinLinMac.yml/badge.svg?branch=main)](https://github.com/Exiv2/exiv2/actions/workflows/on_push_BasicWinLinMac.yml) | [![CI for different Linux distributions](https://github.com/Exiv2/exiv2/actions/workflows/nightly_Linux_distributions.yml/badge.svg?branch=main)](https://github.com/Exiv2/exiv2/actions/workflows/nightly_Linux_distributions.yml) | [![Linux Special Builds on PRs](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_special_buils.yml/badge.svg)](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_special_buils.yml) | | ||
| [![Basic CI for all platforms on push](https://github.com/Exiv2/exiv2/actions/workflows/on_push_BasicWinLinMac.yml/badge.svg?branch=main)](https://github.com/Exiv2/exiv2/actions/workflows/on_push_BasicWinLinMac.yml) | [![CI for different Linux distributions](https://github.com/Exiv2/exiv2/actions/workflows/nightly_Linux_distributions.yml/badge.svg?branch=main)](https://github.com/Exiv2/exiv2/actions/workflows/nightly_Linux_distributions.yml) | [![Linux Special Builds on PRs](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_special_builds.yml/badge.svg)](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_special_builds.yml) | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file is renamed above. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is fine, but note this will lead to a completely new workflow created here (with the same name though), and the old runs will have to be deleted via the API. |
||
| [![Linux-Ubuntu Matrix on PRs](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_matrix.yml/badge.svg)](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_linux_matrix.yml) | [![Mac Matrix on PRs](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_mac_matrix.yml/badge.svg)](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_mac_matrix.yml) | [![Win Matrix on PRs](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_windows_matrix.yml/badge.svg)](https://github.com/Exiv2/exiv2/actions/workflows/on_PR_windows_matrix.yml) | | ||
|
||
<div id="1"> | ||
|
@@ -197,7 +197,7 @@ CMake will detect libiconv of all UNIX like systems including Linux, macOS, UNIX | |
|
||
The library libiconv is a GNU library and we do not recommend using libiconv with Exiv2 when building with Visual Studio. | ||
|
||
Exiv2 includes the file cmake/FindIconv.cmake which contains a guard to prevent CMake from finding libiconv when you build with Visual Studio. This was added because of issues reported when Visual Studio attempted to link libconv libraries installed by Cygwin, or MinGW or gnuwin32. [https://github.com/Exiv2/exiv2/issues/1250](https://github.com/Exiv2/exiv2/issues/1250) | ||
Exiv2 includes the file cmake/FindIconv.cmake which contains a guard to prevent CMake from finding libiconv when you build with Visual Studio. This was added because of issues reported when Visual Studio attempted to link libiconv libraries installed by Cygwin, or MinGW or gnuwin32. [https://github.com/Exiv2/exiv2/issues/1250](https://github.com/Exiv2/exiv2/issues/1250) | ||
|
||
There are build instructions about Visual Studio in libiconv-1.16/INSTALL.window require you to install Cygwin. There is an article here about building libiconv with Visual Studio. [https://www.codeproject.com/Articles/302012/How-to-Build-libiconv-with-Microsoft-Visual-Studio](https://www.codeproject.com/Articles/302012/How-to-Build-libiconv-with-Microsoft-Visual-Studio). | ||
|
||
|
@@ -654,7 +654,7 @@ You can cross compile Exiv2 on Linux for MinGW. We have used the following meth | |
$ sudo dnf install mingw64-gcc-c++ mingw64-filesystem mingw64-expat mingw64-zlib cmake make | ||
``` | ||
|
||
#### 2 Install Dependancies | ||
#### 2 Install Dependencies | ||
|
||
You will need to install x86_64 libraries to support the options you wish to use. By default, you will need libz and expat. Your `dnf` command above has installed them for you. If you wish to use features such as `webready` you should install openssl and libcurl as follows: | ||
|
||
|
@@ -807,7 +807,7 @@ Access to the bmff code is guarded in two ways. Firstly, you have to build the | |
EXIV2API bool enableBMFF(bool enable); | ||
``` | ||
|
||
The return value from `enableBMFF()` is true if the library has been build with bmff support (cmake option -DEXIV2_ANABLE_BMFF=On). | ||
The return value from `enableBMFF()` is true if the library has been build with bmff support (cmake option -DEXIV2_ENABLE_BMFF=On). | ||
|
||
Applications may wish to provide a preference setting to enable bmff support and thereby place the responsibility for the use of this code with the user of the application. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -268,7 +268,7 @@ OPTIMIZE_OUTPUT_VHDL = NO | |
# parses. With this tag you can assign which parser to use for a given | ||
# extension. Doxygen has a built-in mapping, but you can override or extend it | ||
# using this tag. The format is ext=language, where ext is a file extension, and | ||
# language is one of the parsers supported by doxygen: IDL, Java, Javascript, | ||
# language is one of the parsers supported by doxygen: IDL, Java, JavaScript, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm happy to drop files/exclude paths, just let me know what should be skipped.
|
||
# C#, C, C++, D, PHP, Objective-C, Python, Fortran (fixed format Fortran: | ||
# FortranFixed, free formatted Fortran: FortranFree, unknown formatted Fortran: | ||
# Fortran. In the later case the parser tries to guess whether the code is fixed | ||
|
@@ -675,7 +675,7 @@ SHOW_NAMESPACES = YES | |
# The FILE_VERSION_FILTER tag can be used to specify a program or script that | ||
# doxygen should invoke to get the current version for each file (typically from | ||
# the version control system). Doxygen will invoke the program by executing (via | ||
# popen()) the command command input-file, where command is the value of the | ||
# popen()) the command input-file, where command is the value of the | ||
# FILE_VERSION_FILTER tag, and input-file is the name of an input file provided | ||
# by doxygen. Whatever the program writes to standard output is used as the file | ||
# version. For an example see the documentation. | ||
|
@@ -1474,7 +1474,7 @@ EXT_LINKS_IN_WINDOW = NO | |
|
||
FORMULA_FONTSIZE = 10 | ||
|
||
# Use the FORMULA_TRANPARENT tag to determine whether or not the images | ||
# Use the FORMULA_TRANSPARENT tag to determine whether or not the images | ||
# generated for formulas are transparent PNGs. Transparent PNGs are not | ||
# supported properly for IE 6.0, but are supported on all modern browsers. | ||
# | ||
|
@@ -1486,7 +1486,7 @@ FORMULA_FONTSIZE = 10 | |
FORMULA_TRANSPARENT = YES | ||
|
||
# Enable the USE_MATHJAX option to render LaTeX formulas using MathJax (see | ||
# http://www.mathjax.org) which uses client side Javascript for the rendering | ||
# http://www.mathjax.org) which uses client side JavaScript for the rendering | ||
# instead of using pre-rendered bitmaps. Use this if you do not have LaTeX | ||
# installed or if you want to formulas look prettier in the HTML output. When | ||
# enabled you may also need to install MathJax separately and configure the path | ||
|
@@ -1556,7 +1556,7 @@ MATHJAX_CODEFILE = | |
SEARCHENGINE = YES | ||
|
||
# When the SERVER_BASED_SEARCH tag is enabled the search engine will be | ||
# implemented using a web server instead of a web client using Javascript. There | ||
# implemented using a web server instead of a web client using JavaScript. There | ||
# are two flavors of web server based searching depending on the EXTERNAL_SEARCH | ||
# setting. When disabled, doxygen will generate a PHP script for searching and | ||
# an index file used by the script. When EXTERNAL_SEARCH is enabled the indexing | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
# This module provides function for joining paths | ||
# known from from most languages | ||
# known from most languages | ||
Comment on lines
1
to
+2
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My changes are for spelling (duplicate words are often detected by classic spell checkers) and don't cover grammar. In this case, even w/ this fix, the text doesn't make much sense. |
||
# | ||
# Original license: | ||
# SPDX-License-Identifier: (MIT OR CC0-1.0) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -323,7 +323,7 @@ Build: (11) | |
0001329 Error during cmake with gcc version parsing | ||
0001310 Provide support for msys/2.0 | ||
0001299 exiv2-0.26-trunk.tar.gz changed on download server | ||
0001270 Using libexiv2.a/.lib in multhreaded app segfaults. | ||
0001270 Using libexiv2.a/.lib in multithreaded app segfaults. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some projects don't like fixing changelogs. Happy to drop if that's the case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is fine for me to fix typos in the changlog too 👍 |
||
0001237 Report CMake/MinGW issues to Kitware | ||
0001188 Provide build support for C++11 | ||
0001174 Visual Studio Support Enhancements | ||
|
@@ -643,9 +643,9 @@ Changes from version 0.25 to 0.26 | |
- 0001145: Respect Sony/Minolta lenses with shared LensID such as Tamron SP AF 17-50mm F2.8 XR Di II LD | ||
- 0001144: Sigma 10-20mm f/4-5.6 EX DC is detected as Tamaron | ||
(Simon Harhues) | ||
- 0001142: Manual lens does not get recogniced: Beroflex zoom 500mm | ||
- 0001142: Manual lens does not get recognized: Beroflex zoom 500mm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This project has a lot of en-GB. My default is en-US, so the corrections here are en-US. Happy to switch if there's a strong preference. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would wait for @clanmills feedback on this matter. He has been the main maintainer of the project for many years, and I am sure he will have something to say about this 😸. I do not have a strong preference for one or another. |
||
(Simon Harhues / Niels Kristian Bech Jensen) | ||
- 0001141: Manual lens does not get recogniced: Pentax macro 100mm | ||
- 0001141: Manual lens does not get recognized: Pentax macro 100mm | ||
(Simon Harhues / Niels Kristian Bech Jensen) | ||
- 0001118: Add support for ZEISS Loxia 2/50 lens | ||
(Eugen Neu) | ||
|
@@ -689,7 +689,7 @@ Changes from version 0.25 to 0.26 | |
- 0000922: Add options -pS and -dI to application exiv2 | ||
- 0000855: Segfault when accessing focalLength with 0.23 | ||
(Tobias E.) | ||
- 0000756: Access to ICC Profile (TAG: 0x8773) data in Exif as uninterpretted binary | ||
- 0000756: Access to ICC Profile (TAG: 0x8773) data in Exif as uninterpreted binary | ||
(Ray NA) | ||
- 0000676: Patch for reading ICC color profiles | ||
(Andreas Huggel) | ||
|
@@ -783,7 +783,7 @@ Changes from version 0.25 to 0.26 | |
|
||
* Testing: (6) | ||
- 0001230: Bug Hunt for v0.26 | ||
- 0001207: digiKam maintenance tool to synchronize files metadata and database crash in Exiv2 (re-entrancy issue ?) | ||
- 0001207: digiKam maintenance tool to synchronize files metadata and database crash in Exiv2 (reentrancy issue ?) | ||
(Uwe Haider) | ||
- 0001057: Implement target/modifier - (stdin/stdout) for exiv2 options -i (insert) and -e (extract) | ||
- 0001045: Add COPYRIGHT file to test/data/ | ||
|
@@ -1192,7 +1192,7 @@ Changes from version 0.23 to 0.24 | |
(Reported by S. Verdoold, patch by Pascal de Bruijn) | ||
- 0000861: Sigma 18-250mm not properly recognised on Pentax | ||
(Reported by S. Verdoold, patch by Pascal de Bruijn) | ||
- 0000862: Video code is failing the test suite (on all plaforms) | ||
- 0000862: Video code is failing the test suite (on all platforms) | ||
(Robin Mills, Abhinav Badola) | ||
- 0000865: Patches for locale and boost issue (Patches by Mario anyc) | ||
- 0000868: Support for two lens for sony mount | ||
|
@@ -1463,7 +1463,7 @@ Changes from version 0.20 to 0.21 | |
(Patch by Matthias Baas) | ||
- Added ExifKey::defaultCount() to access the new count reference | ||
information. | ||
- Fixed zlib uncompression of large PNG metadata buffers. | ||
- Fixed zlib decompression of large PNG metadata buffers. | ||
- Improved determination of MIME type. | ||
- Updated Canon makernote. (Greg Mansfield, Axel Waggershauser) | ||
- Updated Olympus makernote. (Greg Mansfield) | ||
|
@@ -1713,7 +1713,7 @@ Changes from version 0.18 to 0.18.1 | |
support for multiple TIFF tree structures. | ||
|
||
* MSVC related | ||
- 0000621: windows librarys are forcing a link to | ||
- 0000621: windows libraries are forcing a link to | ||
..\..\..\zlib-1.2.3\projects\visual6\blah\blah. | ||
(Reported by Peter J. Ersts, fix by Robin Mills) | ||
|
||
|
@@ -2051,7 +2051,7 @@ Changes from version 0.12 to 0.13 | |
and insert actions. | ||
|
||
* Exiv2 library | ||
- 0000503: [metadata] Tiff generated by photoshop crashes exiv2 | ||
- 0000503: [metadata] Tiff generated by Photoshop crashes exiv2 | ||
(digikam bug 139658). | ||
- 0000502: [iptc] New TIFF parser: Decode IPTC from Exif.Image.IPTCNAA. | ||
(Reported by Walter Hangartner) | ||
|
@@ -2124,7 +2124,7 @@ Changes from version 0.11 to 0.12 | |
- [exif] Updated Minolta makernote. (Gilles Caulier, Paul Tribick) | ||
|
||
* MSVC related | ||
- 0000487: Crash in exiv2.exe (built with VC++ 2005 Express) when examing TIFF | ||
- 0000487: Crash in exiv2.exe (built with VC++ 2005 Express) when examining TIFF | ||
images (Reported with patch by Dimitri Schoolwerth) | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally my PRs only look at individual words, but I've been toying with this related task of identifying duplicated words. This repository was good input for my tool.
If feedback on this feature is negative, I may drop it going forward.
For simplicity, I've tagged these commits with the word that was duplicated, although, I might change my commit messages based on feedback.