Adding static analysis with PVS-Studio

[piponazo]

In the middle of 2021 I got a free license for PVS-Studio so that we can use it to detect defects in the codebase:

https://pvs-studio.com/en/order/open-source-license/

In this PR I will try to add the automatic execution of this static analyser into our CI pipeline.

Note that this is just storing the result of the static analysis as an artifact in the Github Actions page. Example:
https://github.com/Exiv2/exiv2/actions/runs/1757710199

However we are not blocking PRs in case of emerging new defects detected by the tool. I can try to investigate that in a following PR.

[codecov]

Codecov Report

Merging #2061 (4746bb4) into main (fde0f9e) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2061      +/-   ##
==========================================
- Coverage   62.04%   61.82%   -0.22%     
==========================================
  Files          96       96              
  Lines       19194    19098      -96     
  Branches     9833     9817      -16     
==========================================
- Hits        11909    11808     -101     
- Misses       4978     4995      +17     
+ Partials     2307     2295      -12     

Impacted Files	Coverage Δ
src/types.cpp	87.77% <ø> (-0.06%)	⬇️
src/safe_op.hpp	69.23% <0.00%> (-27.65%)	⬇️
include/exiv2/slice.hpp	69.64% <0.00%> (-21.89%)	⬇️
include/exiv2/error.hpp	60.71% <0.00%> (-4.81%)	⬇️
src/utils.cpp	38.46% <0.00%> (-1.93%)	⬇️
include/exiv2/value.hpp	82.96% <0.00%> (-0.55%)	⬇️
src/enforce.hpp	75.00% <0.00%> (+2.77%)	⬆️
src/getopt.cpp	67.30% <0.00%> (+5.76%)	⬆️
include/exiv2/metadatum.hpp	88.88% <0.00%> (+16.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde0f9e...4746bb4. Read the comment docs.

[hassec]

However we are not blocking PRs in case of emerging new defects detected by the tool. I can try to investigate that in a following PR.

Also not for this MR, but maybe with the above to-do: is there anyway we can display the results somewhere without having to download the artifact?

[hassec]

LGTM 👍

[piponazo]

Also not for this MR, but maybe with the above to-do: is there anyway we can display the results somewhere without having to download the artifact?

I have added a new issue describing some of the improvements we could do regarding PVS-Studio: #2074. Hopefully somebody will tackle those things at some point 😉

[hassec]

LGTM 👍