Update XMP tags for IPTC 2021.1 #2053
Conversation
Changes: 1. Add/update tags. 2. According to the standard, several tags in `Xmp.iptc.<property>` and `Xmp.iptcExt.<property>`, had been wrongly added, as they only exist as part of a struct used by a tag. The incorrect tags have been marked as deprecated in the label and description. 3. Update existing test with translated output. Ref: [IPTC Photo Metadata Standard 2021.1](https://www.iptc.org/std/photometadata/specification/IPTC-PhotoMetadata-2021.1.html)
postscript-dev
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #2053 +/- ##
==========================================
- Coverage 61.47% 5.72% -55.76%
==========================================
Files 96 96
Lines 19195 18955 -240
Branches 9841 9843 +2
==========================================
- Hits 11801 1085 -10716
- Misses 5080 17682 +12602
+ Partials 2314 188 -2126
Continue to review full report at Codecov.
|
|
@kevinbackhouse: I think that the codeconv diff is reduced because I added a lot of translation values. I can add a Python test that includes these. |
|
What a coincidence. Today I was looking at the IPTC code and I also found out about the new standard. I will join the review process if you do not mind 😉 |
| { "OrganisationInImageCode", N_("Code of featured Organisation"), "bag Text", xmpBag, xmpExternal, N_("Code from controlled vocabulary for identifying the organisation or company which is featured in the image.") }, | ||
| { "AddlModelInfo", N_("Additional model information"), "Text", xmpText, xmpExternal, N_("Information about the ethnicity and other facets of the model(s) in a model-released image.") }, | ||
| { "OrganisationInImageCode", N_("Code of featured Organisation"), "bag Text", xmpBag, xmpExternal, N_("Code from a controlled vocabulary for identifying the organisation or company which is featured in the image.") }, | ||
| { "AboutCvTerm", N_("CV-Term About Image"), "bag CVTerm", xmpBag, xmpExternal, N_("One or more topics, themes or entities the content is about, each one expressed by a term from a Controlled Vocabulary.") }, |
There was a problem hiding this comment.
Should this be AboutCvTerms (with s at the end)?
I noticed that it appears with an s in this link:
https://www.iptc.org/std/photometadata/specification/iptc-pmd-schema_2019.1.1.json
But in https://www.iptc.org/std/photometadata/specification/iptc-pmd-techreference_2021.1.json
I found entries with s and without it.
I am not sure yet how we are translating those specifications to our code structures.
There was a problem hiding this comment.
For the IPTC 2021.1 specification, I used the XMP Specs name rather than the JSON Specs name. This mapped to the XML files (i.e. .xmp) and seemed like the correct one to use - unless you know differently. It is worth noting that the ExifTool tags also use the XMP Specs name.
After your comment, I looked at the JSON Specs values and lots of the names are different but I don't know why. @bquinn, can you help with this?
There was a problem hiding this comment.
Thanks for the answer. I just wanted to know how we were doing it 😉
|
@postscript-dev Peter, I'd also like to express my appreciation and admiration for your work here. I'm so happy to see Exiv2 moving without me pushing. It was a lot of work in 2020 and 2021 to deal with BMFF, three "dot" releases and to write the book. The effort has been rewarded by you and @kmilos and @alexvanderberkel and @hassec and and @1div0 joining Team Exiv2. And @kevinbackhouse, @piponazo, @neheb and @nehaljwani have continued to make great contributions. Who knows, maybe @D4N will rejoin us. Dan: you know you are welcome. I really will retire from Exiv2 during 2022. I'd like to keep 0.27-maintenance alive while we move towards the C++XX release of Exiv2. @kevinbackhouse has done such good work on security, I feel it's right that I should support that effort by releasing "dots" when needed. @nehaljwani I'm very busy this week and next with family matters. I haven't forgotten that I have to give you feedback on the GitHub version of exiv2.org. I will. However I may not be able to do this until 2022-01-24. |
|
@piponazo: Do you know why the codeconv is failing? The EXV_PRINT_VOCABULARY_MULTI() reference should be triggered by printing the |
I would not worry too much about the codecov reports. I noticed in the last months/years that the reports are not precise, in fact when I run the code coverage locally with I would ignore codecov at the moment. I can check in the future how we are using codecov and try to determine how we can improve the experience with it. |
Update tags according to the new IPTC Photo Metadata Standard 2021.1 specification. This includes changes to Exiv2 tags in
Xmp.iptc.,Xmp.iptcExt.,Xmp.Xmp.andXmp.photoshop..According to the standard, several tags in
Xmp.iptc.andXmp.iptcExt.had been wrongly added, as they only exist as part of a struct used by a tag. The incorrect tags have been marked as deprecated in the label and description.Closes #1959