Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation on 0.27-maintenance to respect ctest #2033

Merged
merged 7 commits into from
Dec 20, 2021

Conversation

clanmills
Copy link
Collaborator

Initial changes to documentation to support CTest. I intend to integrate changes from main/README.md in this PR.

@clanmills clanmills marked this pull request as draft December 17, 2021 14:04
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #2033 (5e2b777) into 0.27-maintenance (959f452) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           0.27-maintenance    #2033      +/-   ##
====================================================
- Coverage             58.74%   58.72%   -0.03%     
====================================================
  Files                   146      146              
  Lines                 23004    23004              
  Branches              12596    12596              
====================================================
- Hits                  13513    13508       -5     
- Misses                 6689     6693       +4     
- Partials               2802     2803       +1     
Impacted Files Coverage Δ
src/actions.cpp 62.09% <0.00%> (-0.32%) ⬇️
src/tiffvisitor_int.cpp 76.65% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959f452...5e2b777. Read the comment docs.

README.md Outdated Show resolved Hide resolved
@clanmills clanmills mentioned this pull request Dec 17, 2021
@clanmills clanmills changed the title fix_README_ctest Updating documentation on 0.27-maintenance to respect ctest Dec 17, 2021
@clanmills
Copy link
Collaborator Author

@kmilos. I'm getting 100% test failure with the Visual Studio build. I have to provide -C Release to get ctest to run at all. I'll update README.md about that.

You mentioned something about 'git config'. Is that something I need to deal with? Any ideas what might be the matter?

I'm sure it's related to line-endings.

@kmilos
Copy link
Collaborator

kmilos commented Dec 17, 2021

No, that was very Cygwin specific.

I can take a look, but might be a while, the dad hat rarely comes off during the weekend...

@kmilos
Copy link
Collaborator

kmilos commented Dec 17, 2021

@clanmills The Windows CI seems to be ok? I see only codecov failing (no idea why)....

@clanmills
Copy link
Collaborator Author

Keep the Dad hat on. The CI is happy.

I installed cmake 3.22, pulled down fresh code and built. Looks good.

C:\Users\rmills\gnu\github\exiv2\0.27-maintenance\build>ctest -C Release
Test project C:/Users/rmills/gnu/github/exiv2/0.27-maintenance/build
    Start 1: bashTests
1/5 Test #1: bashTests ........................   Passed   46.33 sec
    Start 2: bugfixes
2/5 Test #2: bugfixes .........................   Passed  101.32 sec
    Start 3: tiffTests
3/5 Test #3: tiffTests ........................   Passed    0.45 sec
    Start 4: versionTest
4/5 Test #4: versionTest ......................   Passed    0.28 sec
    Start 5: unit_tests
5/5 Test #5: unit_tests .......................   Passed    0.07 sec

100% tests passed, 0 tests failed out of 5

Total Test time (real) = 481.96 sec

C:\Users\rmills\gnu\github\exiv2\0.27-maintenance\build>

Grampa is talking shit as always.

@clanmills
Copy link
Collaborator Author

Codecov is a "bloody old woman!". It's complaining because code coverage has gone down (by almost nothing). We'll ignore that.

I'm sure I'll add more polish/fixes to this PR over the weekend.

… It's not possible to add lensTest into 0.27-maintenance without modifying Exiv2::getExiv2ConfigPath().
@clanmills clanmills marked this pull request as ready for review December 19, 2021 12:05
kmilos
kmilos previously approved these changes Dec 20, 2021
@mergify mergify bot dismissed kmilos’s stale review December 20, 2021 11:45

Pull request has been modified.

@clanmills
Copy link
Collaborator Author

This PR has been sitting in MSYS2 doing "setup" for 5 hours, so I cancelled it. Everything else passed and this PR cannot be involved in setting up the build machine.

I looked at the documentation concerning codecov. I think we can set threshold in codecov.yml to ignore negative code coverage. The codecov documentation needs more careful investigation to decide what should be done.

I'm going to merge.

@clanmills clanmills merged commit 8b9f2a9 into 0.27-maintenance Dec 20, 2021
@clanmills clanmills deleted the fix_README_ctest branch December 20, 2021 17:03
@kmilos
Copy link
Collaborator

kmilos commented Dec 20, 2021

Yeah, I've seen GHA jobs get stuck before on occasion...

@kmilos kmilos added this to the v0.27.6 milestone Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants