Switch Cygwin CI to GHA

[kmilos]

No description provided.

[kmilos]

Duh, the default shell for Cygwin action is PowerShell, trying its multi-line break instead...

Edit: Switched to bash eventually.

Also, not sure why AppVeyor is still attempting to run when the recipe has been removed?

[clanmills]

That looks about right. Let's see how/if it works out on the CI.

You're using the correct approach to install the dependencies and build with CMake without using conan. I've never succeeded in building with conan on Cygwin.

The code in appveyor_mingw_cygwin.yml use apt-cyg to install the dependencies and builds with cmake. Appveyor runs the cmd shell.

[kmilos]

Yeah, and had to turn unit test off (same on AppVeyor) as there is not gtest on Cygwin available ootb.

The action is made by the same person who did the action for MSYS2 setup (and incidentally the VS shell), so should be usable 🤞

[kmilos]

Almost there, now just a couple of tests fail, presumably because of line ending difference: ctest is run from PowerShell and not from bash like it was on AppVeyor...

[clanmills]

Here are the notes I made when I created this last year: https://help.appveyor.com/discussions/questions/51961-building-on-mingw-64-and-cygwin64

When this PR flies, we don't need appveyor to run appveyor_mingw_cygwin.yml at all. I can't remember how this is triggered. I'm fairly sure I had to register something on the appveyor web-site.

[codecov]

Codecov Report

Merging #2032 (de71680) into 0.27-maintenance (959f452) will not change coverage.
The diff coverage is n/a.

❗ Current head de71680 differs from pull request most recent head 589079a. Consider uploading reports for the commit 589079a to get more accurate results

@@                Coverage Diff                @@
##           0.27-maintenance    #2032   +/-   ##
=================================================
  Coverage             58.74%   58.74%           
=================================================
  Files                   146      146           
  Lines                 23004    23004           
  Branches              12596    12596           
=================================================
  Hits                  13513    13513           
  Misses                 6689     6689           
  Partials               2802     2802           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959f452...589079a. Read the comment docs.

[clanmills]

@kmilos Appveyor is running the cmd.exe (DOS console) and I execute bash to run the bash build script. I build the bash build script line-by-line with ; command separators. The bash build script is a one-liner.

set CMD=mkdir build
set CMD=CMD=%CMD%; cd build
...
C:\cygwin64\bin\bash -c "%CMD%"

[clanmills]

I'm fairly sure the build is failing in Appveyor because you've deleted appveyor_mingw_cygwin.yml. I think I had to register something with appveyor to tell him to use that file.

I remember thinking "this will only work on 0.27-maintenance". Ummm. I can't remember how it works and I can't find anything on appveyor. @kevinbackhouse Do you know how appveyor knows to read the file appveyor_mingw_cygwin.yml?

[kmilos]

Thanks Robin, I was well aware of that. The problem was that the default bash launcher suggested by the action author changes the working directory to $HOME even w/ --norc, so I had to remove the --login option.

But we're back to square one (same as PowerShell), there are still a couple of failing tests...

[clanmills]

@kmilos.

I haven't understood what you are saying about the shell. Most of the tests pass, so it's mostly working fine. This looks like a solid/repeatable error. I'll try this after lunch on Windows.

At the moment, I'm giving README.md a thorough overhaul to deal with ctest.

[clanmills]

I've found the appveyor settings. https://ci.appveyor.com/project/clanmills/exiv2/settings. I will delete the project.

Later today, I'll investigate the other build failures on Windows. There can't be much wrong.

[kmilos]

I've found the appveyor settings. https://ci.appveyor.com/project/clanmills/exiv2/settings. I will delete the project.

Please wait until we get this working ;)

The suggested workaround to check out Unix line endings also doesn't work currently... I'm taking a break from this one...

[clanmills]

Whoops. I've already deleted it.

I asked in a review for that code concerning the line-endings to be changed and the engineer refused. He's the only contributor I have ever fired.

[kmilos]

Ok, figured out why the git config wasn't working (executed in the wrong shell), so this is my last attempt before touching tests.

[kmilos]

Bingo!

[piponazo]

Great! Finally all the pipelines running on GHA! 🎊

[clanmills]

You're almost as smart as I used to be!

Do you know the Country Song "As Good As I One Was"? https://www.youtube.com/watch?v=ldQrapQ4d0Y

[kmilos]

Can't say I did :D

[clanmills]

"I'm not as good as I once was.
But I'm as good once, as I ever was!"