Treat Exif.Sony1.PreviewImage as undefined tag #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2015 +/- ##
==========================================
+ Coverage 61.16% 61.17% +0.01%
==========================================
Files 96 96
Lines 19255 19251 -4
Branches 9862 9858 -4
==========================================
Hits 11777 11777
+ Misses 5135 5134 -1
+ Partials 2343 2340 -3
Continue to review full report at Codecov.
|
clanmills
approved these changes
Dec 5, 2021
There was a problem hiding this comment.
Perfect. Less code is almost always better. In this case, it get us totally out of trouble.
The tag is always treated as "unknown/count==0". The tag is still understood and documented:
$ taglist ALL | grep Sony1 | grep PreviewImage | grep -v Size
Sony1.PreviewImage,8193,0x2001,Sony1,Exif.Sony1.PreviewImage,Undefined,"JPEG preview image"
Sony2.PreviewImage,8193,0x2001,Sony1,Exif.Sony1.PreviewImage,Undefined,"JPEG preview image"
$
If David works on this, we might give this more tuning/polish. However for now it get us out of trouble. I've very pleased about this.
|
@Mergifyio backport 0.27-maintenance |
✅ Backports have been created
|
kevinbackhouse
added a commit
that referenced
this pull request
Dec 14, 2021
Treat Exif.Sony1.PreviewImage as undefined tag (backport #2015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2001
We should treat Exif.Sony1.PreviewImage as an undefined tag, as suggested by @clanmills in this comment.
In the future, we may be able to do something more sophisticated with Exif.Sony1.PreviewImage. For example, something like what I tried in #2008 might enable us to correctly update the offset that's stored in the tag when modifying the metadata causes us to change the size of the file.