Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Update git templates from old-master #1988

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

postscript-dev
Copy link
Collaborator

The Exiv2 GitHub templates were lost during the transition from the master branch to main branch.

@postscript-dev postscript-dev added this to the v1.00 milestone Oct 26, 2021
@postscript-dev postscript-dev self-assigned this Oct 26, 2021
@postscript-dev
Copy link
Collaborator Author

Do we still need the text at the beginning? e.g.,

---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: FeatureRequest
assignees: ''
---

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #1988 (3a1a9db) into main (76a9377) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1988      +/-   ##
==========================================
+ Coverage   61.26%   61.29%   +0.02%     
==========================================
  Files          96       96              
  Lines       19105    19110       +5     
  Branches     9756     9760       +4     
==========================================
+ Hits        11705    11713       +8     
+ Misses       5079     5076       -3     
  Partials     2321     2321              
Impacted Files Coverage Δ
src/actions.cpp 61.29% <0.00%> (+0.15%) ⬆️
src/exiv2.cpp 58.18% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a9377...3a1a9db. Read the comment docs.

@postscript-dev postscript-dev removed the request for review from kevinbackhouse October 26, 2021 15:19
@kmilos
Copy link
Collaborator

kmilos commented Oct 27, 2021

Do we still need the text at the beginning?

It think so, especially to set up the tags and assignees... However, it seems issue templates moved now to a more sophisticated YAML scheme, but this one is still good enough for the time being.

@kmilos kmilos merged commit a97d747 into Exiv2:main Oct 27, 2021
@postscript-dev postscript-dev deleted the add_git_templates branch November 8, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants