-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BMFF Performance boost: don't read boxes we're not interested in #1974
Conversation
@Mergifyio backport 0.27-maintenance |
🟠 Waiting for conditions
|
LGTM 👍 Can you please do a tiny cosmetic whitespace change on L78 please while we're committing to this file? In the last PR (CR3 preview) I added a space to the four-byte sig of "xml ", but that then pushed the comment to the right... can you just re-align the comment please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LG2M.
The macOS build failures look like a new problem related to conan. They're not caused by this PR. |
✅ Backports have been created
|
Performance boost: don't read boxes we're not interested in (backport #1974)
This speeds up handling of large ISOBMFF files by not reading the mdat box.
Fixes #1961
Before:
After: