Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMFF Performance boost: don't read boxes we're not interested in #1974

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

dhoulder
Copy link
Contributor

@dhoulder dhoulder commented Oct 19, 2021

This speeds up handling of large ISOBMFF files by not reading the mdat box.
Fixes #1961

Before:

david@blackbox:build$ time bash -c 'for i in $(seq 1 100); do ./bin/exiv2 -pp ~/Downloads/Canon-R5.CR3 >/dev/null; done'

real	0m2.937s
user	0m0.782s
sys	0m2.159s

After:

david@blackbox:build$ time bash -c 'for i in $(seq 1 100); do ./bin/exiv2 -pp ~/Downloads/Canon-R5.CR3 >/dev/null; done'

real	0m0.534s
user	0m0.327s
sys	0m0.214s

@dhoulder
Copy link
Contributor Author

@Mergifyio backport 0.27-maintenance

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2021

backport 0.27-maintenance

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@kmilos
Copy link
Collaborator

kmilos commented Oct 20, 2021

LGTM 👍

Can you please do a tiny cosmetic whitespace change on L78 please while we're committing to this file? In the last PR (CR3 preview) I added a space to the four-byte sig of "xml ", but that then pushed the comment to the right... can you just re-align the comment please?

Copy link
Collaborator

@1div0 1div0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LG2M.

@kevinbackhouse
Copy link
Collaborator

The macOS build failures look like a new problem related to conan. They're not caused by this PR.

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021

backport 0.27-maintenance

✅ Backports have been created

@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Oct 20, 2021
clanmills added a commit that referenced this pull request Oct 21, 2021
Performance boost: don't read boxes we're not interested in (backport #1974)
@clanmills clanmills changed the title Performance boost: don't read boxes we're not interested in BMFF Performance boost: don't read boxes we're not interested in Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't read the mdat box from ISOBMFF files
4 participants