Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readOrThrow and seekOrThrow to BasicIo #1967

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

readOrThrow and seekOrThrow were previously added as static functions in several sources files because we didn't want to change the header files on the 0.27-maintenance branch. I would like to add them to the API in 1.00.

@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Oct 17, 2021
@kevinbackhouse kevinbackhouse marked this pull request as draft October 17, 2021 14:25
@kevinbackhouse kevinbackhouse added enhancement feature / functionality enhancements refactoring Cleanup / Simplify code -> more readable / robust labels Oct 17, 2021
@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #1967 (68473d9) into main (c5101e0) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
- Coverage   61.26%   61.23%   -0.03%     
==========================================
  Files          96       96              
  Lines       19105    19091      -14     
  Branches     9756     9756              
==========================================
- Hits        11705    11691      -14     
  Misses       5079     5079              
  Partials     2321     2321              
Impacted Files Coverage Δ
include/exiv2/basicio.hpp 80.00% <ø> (ø)
src/image.cpp 64.41% <64.70%> (-0.69%) ⬇️
src/webpimage.cpp 48.81% <80.95%> (-0.60%) ⬇️
src/basicio.cpp 48.96% <100.00%> (+0.56%) ⬆️
src/jpgimage.cpp 69.91% <100.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5101e0...68473d9. Read the comment docs.

@kevinbackhouse kevinbackhouse marked this pull request as ready for review October 17, 2021 14:52
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@kevinbackhouse
Copy link
Collaborator Author

Thanks @piponazo!

@kevinbackhouse kevinbackhouse merged commit fde8ed0 into Exiv2:main Nov 8, 2021
@kevinbackhouse kevinbackhouse deleted the ReadOrThrow branch November 8, 2021 22:33
@ghost
Copy link

ghost commented Nov 29, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature / functionality enhancements refactoring Cleanup / Simplify code -> more readable / robust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants