-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readOrThrow and seekOrThrow to BasicIo #1967
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1967 +/- ##
==========================================
- Coverage 61.26% 61.23% -0.03%
==========================================
Files 96 96
Lines 19105 19091 -14
Branches 9756 9756
==========================================
- Hits 11705 11691 -14
Misses 5079 5079
Partials 2321 2321
Continue to review full report at Codecov.
|
e0455fe
to
68473d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
Thanks @piponazo! |
readOrThrow
andseekOrThrow
were previously added as static functions in several sources files because we didn't want to change the header files on the 0.27-maintenance branch. I would like to add them to the API in 1.00.