Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending Nikon3.ColorBalance version coverage #1944

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Oct 4, 2021

This is going by https://exiftool.org/TagNames/Nikon.html exiftool code study of 0x0097 tag handling: just adding versions already covered, not adding any new decoders.

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #1944 (5291323) into main (2b040e9) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 5291323 differs from pull request most recent head 2074f82. Consider uploading reports for the commit 2074f82 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1944      +/-   ##
==========================================
+ Coverage   61.12%   61.13%   +0.01%     
==========================================
  Files          96       96              
  Lines       19068    19068              
  Branches     9745     9745              
==========================================
+ Hits        11656    11658       +2     
+ Misses       5093     5091       -2     
  Partials     2319     2319              
Impacted Files Coverage Δ
src/makernote_int.cpp 67.62% <ø> (ø)
src/nikonmn_int.cpp 46.31% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b040e9...2074f82. Read the comment docs.

@kevinbackhouse
Copy link
Collaborator

#1943 should fix the macOS CI failure. You might have to rebase after it's merged.

@kmilos kmilos marked this pull request as draft October 4, 2021 11:39
@kmilos
Copy link
Collaborator Author

kmilos commented Oct 4, 2021

Thanks, will do. I'd like to re-check a few more recent models anyway...

@kmilos kmilos marked this pull request as ready for review October 4, 2021 19:04
@kevinbackhouse
Copy link
Collaborator

@kmilos: Is this ready to merge?

@kmilos
Copy link
Collaborator Author

kmilos commented Oct 15, 2021

Yes. I was hoping to also try to cover ver "0224" w/ my D5600, but not sure I'll have the time, so that'll come in a separate PR.

@kevinbackhouse kevinbackhouse merged commit 71744d5 into main Oct 15, 2021
@mergify mergify bot deleted the nikon_colorbalance branch October 15, 2021 20:47
@kmilos kmilos added enhancement feature / functionality enhancements makerNote Anything related to one of the various supported MakerNote formats labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature / functionality enhancements makerNote Anything related to one of the various supported MakerNote formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants