-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending Nikon3.ColorBalance version coverage #1944
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1944 +/- ##
==========================================
+ Coverage 61.12% 61.13% +0.01%
==========================================
Files 96 96
Lines 19068 19068
Branches 9745 9745
==========================================
+ Hits 11656 11658 +2
+ Misses 5093 5091 -2
Partials 2319 2319
Continue to review full report at Codecov.
|
#1943 should fix the macOS CI failure. You might have to rebase after it's merged. |
Thanks, will do. I'd like to re-check a few more recent models anyway... |
cb41f83
to
5a4ec76
Compare
5a4ec76
to
4205e03
Compare
@kmilos: Is this ready to merge? |
Yes. I was hoping to also try to cover ver "0224" w/ my D5600, but not sure I'll have the time, so that'll come in a separate PR. |
This is going by
https://exiftool.org/TagNames/Nikon.htmlexiftool code study of 0x0097 tag handling: just adding versions already covered, not adding any new decoders.