Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exiv2 -pR for Sony images (#1805) #1929

Merged
merged 3 commits into from
Jan 9, 2022

Conversation

postscript-dev
Copy link
Collaborator

Closes #1805

@postscript-dev postscript-dev added bug samples makerNote Anything related to one of the various supported MakerNote formats labels Sep 26, 2021
@postscript-dev postscript-dev self-assigned this Sep 26, 2021
@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #1929 (6758e72) into main (fde8ed0) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1929      +/-   ##
==========================================
- Coverage   61.16%   61.15%   -0.01%     
==========================================
  Files          96       96              
  Lines       19255    19258       +3     
  Branches     9862     9863       +1     
==========================================
  Hits        11777    11777              
- Misses       5135     5138       +3     
  Partials     2343     2343              
Impacted Files Coverage Δ
src/image.cpp 63.99% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde8ed0...6758e72. Read the comment docs.

kevinbackhouse
kevinbackhouse previously approved these changes Oct 9, 2021
kevinbackhouse
kevinbackhouse previously approved these changes Oct 15, 2021
`exiv2 -pR` failed to process Sony makernotes. Fix checks if
makernotes header has Sony string, then uses correct offset.

Fix supplied by @clanmills
@postscript-dev postscript-dev removed the request for review from hassec January 9, 2022 15:24
@postscript-dev postscript-dev merged commit 629442d into Exiv2:main Jan 9, 2022
@postscript-dev postscript-dev deleted the fix_exiv2_-pR branch January 9, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug makerNote Anything related to one of the various supported MakerNote formats samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exiv2 -pR false negative "tiff directory length is too large"
2 participants