Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build XMLValidator when XMP is enabled. #1883

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

This is a follow-up to #1878. As discussed here, XMLValidator should only be built when XMP is enabled.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #1883 (b96a49b) into main (f9248f9) will not change coverage.
The diff coverage is n/a.

❗ Current head b96a49b differs from pull request most recent head ce02361. Consider uploading reports for the commit ce02361 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1883   +/-   ##
=======================================
  Coverage   60.79%   60.79%           
=======================================
  Files          96       96           
  Lines       18962    18962           
  Branches     9516     9516           
=======================================
  Hits        11527    11527           
  Misses       5134     5134           
  Partials     2301     2301           
Impacted Files Coverage Δ
src/xmp.cpp 76.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9248f9...ce02361. Read the comment docs.

@clanmills clanmills self-requested a review August 27, 2021 16:43
@kevinbackhouse kevinbackhouse merged commit 0a02b3f into Exiv2:main Aug 27, 2021
@kevinbackhouse kevinbackhouse deleted the XMLValidatorBuild branch August 27, 2021 16:45
@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants