Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if the size of the preview is greater than 1MB #1882

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes: #1881

Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=37492

See #1881 for discussion of this issue.

@kevinbackhouse kevinbackhouse added bug OSS-Fuzz Bug reported by https://google.github.io/oss-fuzz/ labels Aug 27, 2021
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #1882 (ddd1c47) into main (f9248f9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
+ Coverage   60.79%   60.81%   +0.02%     
==========================================
  Files          96       96              
  Lines       18962    18963       +1     
  Branches     9516     9517       +1     
==========================================
+ Hits        11527    11533       +6     
+ Misses       5134     5131       -3     
+ Partials     2301     2299       -2     
Impacted Files Coverage Δ
src/tiffvisitor_int.cpp 76.23% <100.00%> (+0.47%) ⬆️
src/jpgimage.cpp 70.19% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9248f9...ddd1c47. Read the comment docs.

@clanmills clanmills self-requested a review August 27, 2021 16:45
@kevinbackhouse
Copy link
Collaborator Author

@Mergifyio backport 0.27-maintenance

@mergify
Copy link
Contributor

mergify bot commented Aug 27, 2021

Command backport 0.27-maintenance: pending

Waiting for the pull request to get merged

@mergify
Copy link
Contributor

mergify bot commented Aug 27, 2021

Command backport 0.27-maintenance: success

Backports have been created

@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Sep 2, 2021
kevinbackhouse added a commit that referenced this pull request Sep 5, 2021
Throw an error if the size of the preview is greater than 1MB (backport #1882)
@clanmills clanmills mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OSS-Fuzz Bug reported by https://google.github.io/oss-fuzz/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large allocation in tiffvisitor_int.cpp
2 participants