Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special build mode for OSS-Fuzz #1875

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

This is a follow-up to #1869. It turns out that even the -fsanitize=fuzzer-no-link and -fsanitize=fuzzer flags don't work with the OSS-Fuzz build. Instead, we have to add $LIB_FUZZING_ENGINE as a linker flag when we build the fuzz target. That's because OSS-Fuzz also wants to build for AFL and honggfuzz, not just libFuzzer. Each of those fuzzers uses a different main function wrapper around LLVMFuzzerTestOneInput.

@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #1875 (cee9015) into main (f8bfad1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1875   +/-   ##
=======================================
  Coverage   60.77%   60.77%           
=======================================
  Files          96       96           
  Lines       18887    18887           
  Branches     9498     9498           
=======================================
  Hits        11478    11478           
  Misses       5116     5116           
  Partials     2293     2293           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8bfad1...cee9015. Read the comment docs.

Copy link
Collaborator

@clanmills clanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @kevinbackhouse

My only request is to document these options in README.md.

@kevinbackhouse
Copy link
Collaborator Author

@clanmills: Thanks! I'll update the documentation in a follow-up PR. I want to include hyperlinks to the build script in the OSS-Fuzz repo, so it will be easier if I wait until they have merged my pull request.

@kevinbackhouse kevinbackhouse merged commit 079f130 into Exiv2:main Aug 17, 2021
@clanmills
Copy link
Collaborator

That's fine, @kevinbackhouse I approved it so you could push on with the OSS-Fuzz business. Somebody else could/should take on the documentation.

@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants