Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove most usages of std::make_pair #1874

Merged
merged 2 commits into from
Aug 27, 2021
Merged

remove most usages of std::make_pair #1874

merged 2 commits into from
Aug 27, 2021

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Aug 13, 2021

Better alternatives exist with C++11.

Signed-off-by: Rosen Penev rosenp@gmail.com

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #1874 (4030f82) into main (079f130) will decrease coverage by 0.01%.
The diff coverage is 52.94%.

❗ Current head 4030f82 differs from pull request most recent head e7eddfc. Consider uploading reports for the commit e7eddfc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1874      +/-   ##
==========================================
- Coverage   60.77%   60.76%   -0.02%     
==========================================
  Files          96       96              
  Lines       18887    18887              
  Branches     9498     9493       -5     
==========================================
- Hits        11478    11476       -2     
  Misses       5116     5116              
- Partials     2293     2295       +2     
Impacted Files Coverage Δ
include/exiv2/types.hpp 68.57% <0.00%> (ø)
src/epsimage.cpp 1.67% <0.00%> (ø)
src/tiffvisitor_int.cpp 75.75% <50.00%> (ø)
src/exif.cpp 65.90% <100.00%> (-0.33%) ⬇️
src/iptc.cpp 64.61% <100.00%> (-0.39%) ⬇️
src/tiffcomposite_int.cpp 74.32% <100.00%> (ø)
src/types.cpp 91.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 079f130...e7eddfc. Read the comment docs.

kevinbackhouse
kevinbackhouse previously approved these changes Aug 15, 2021
Better alternatives exist with C++11.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@kevinbackhouse kevinbackhouse merged commit 67746de into Exiv2:main Aug 27, 2021
@neheb neheb deleted the emp branch August 27, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants