Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check value is in range before casting from double to uint32_t (backport #1828) #1832

Merged
merged 4 commits into from
Aug 3, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 3, 2021

This is an automatic backport of pull request #1828 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

(cherry picked from commit db527f4)
…oid undefined behavior.

(cherry picked from commit 1455cc8)
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
(cherry picked from commit ad2e722)
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #1832 (ed1db4a) into main (0e7d80f) will increase coverage by 0.05%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
+ Coverage   60.54%   60.59%   +0.05%     
==========================================
  Files          96       96              
  Lines       18856    18860       +4     
  Branches     9477     9479       +2     
==========================================
+ Hits        11416    11428      +12     
+ Misses       5153     5142      -11     
- Partials     2287     2290       +3     
Impacted Files Coverage Δ
src/tags_int.cpp 76.47% <85.71%> (+0.48%) ⬆️
src/easyaccess.cpp 93.69% <0.00%> (+0.90%) ⬆️
src/crwimage.cpp 62.96% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e7d80f...ed1db4a. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit d3e311f into main Aug 3, 2021
@mergify mergify bot deleted the mergify/bp/main/pr-1828 branch August 3, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants