Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codecov config #1809

Merged
merged 4 commits into from
Jul 30, 2021
Merged

update codecov config #1809

merged 4 commits into from
Jul 30, 2021

Conversation

hassec
Copy link
Member

@hassec hassec commented Jul 29, 2021

This PR includes 3 changes:

  1. start using the new codecov uploader because the bash version is deprecated and will soon stop working see here
  2. ignore the samples and unitTests folders in codecov. I don't think we should measure these, they aren't really part of the exiv2 application.
  3. start using gcovr to generate a summary, which is then used by codecov. This has the benefit that the taken branches are better analyzed. See this example in my fork
    Bit of a bummer that it drops the coverage by ~7% but I guess it's more accurate. And the information that e.g. only one branch of an if() is taken is IMHO potentially useful.

@hassec hassec added the testing Anything related to the tests and their infrastructure label Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1809 (28d4bb3) into main (2488fc8) will decrease coverage by 7.69%.
The diff coverage is n/a.

❗ Current head 28d4bb3 differs from pull request most recent head cdbadcf. Consider uploading reports for the commit cdbadcf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1809      +/-   ##
==========================================
- Coverage   68.22%   60.52%   -7.70%     
==========================================
  Files         151       96      -55     
  Lines       20930    18843    -2087     
  Branches        0     9469    +9469     
==========================================
- Hits        14279    11405    -2874     
+ Misses       6651     5151    -1500     
- Partials        0     2287    +2287     
Impacted Files Coverage Δ
include/exiv2/error.hpp 65.51% <0.00%> (-34.49%) ⬇️
src/utils.cpp 40.38% <0.00%> (-33.09%) ⬇️
src/enforce.hpp 72.22% <0.00%> (-27.78%) ⬇️
src/psdimage.cpp 61.48% <0.00%> (-22.82%) ⬇️
include/exiv2/types.hpp 68.57% <0.00%> (-22.34%) ⬇️
src/xmpsidecar.cpp 70.00% <0.00%> (-21.00%) ⬇️
src/pngimage.cpp 60.05% <0.00%> (-18.73%) ⬇️
src/sonymn_int.cpp 51.26% <0.00%> (-17.72%) ⬇️
src/getopt.cpp 61.53% <0.00%> (-16.90%) ⬇️
src/jpgimage.cpp 70.28% <0.00%> (-16.35%) ⬇️
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2488fc8...cdbadcf. Read the comment docs.

hassec and others added 2 commits July 30, 2021 14:04
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
@hassec hassec merged commit c65941c into Exiv2:main Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to the tests and their infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants