Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SonySInfo1 makernote tags (tag 3000) #1808

Merged
merged 3 commits into from
Jul 30, 2021

Conversation

postscript-dev
Copy link
Collaborator

@postscript-dev postscript-dev commented Jul 29, 2021

  • Add all tags, except the face detection sub-groups and related bookkeeping values.
  • Add testing. SonySInfo1 is currently supported by all Sony cameras so does not need to test for unsupported models.

Source: Exiftool (https://exiftool.org/TagNames/Sony.html)

Add all tags, except the face detection sub-groups and related
bookkeeping values.

Source: Exiftool (https://exiftool.org/TagNames/Sony.html)
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1808 (6ef38ed) into main (f4a85d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1808   +/-   ##
=======================================
  Coverage   68.21%   68.22%           
=======================================
  Files         151      151           
  Lines       20933    20933           
=======================================
+ Hits        14280    14282    +2     
+ Misses       6653     6651    -2     
Impacted Files Coverage Δ
src/tags_int.cpp 87.20% <ø> (ø)
src/tags_int.hpp 90.90% <ø> (ø)
src/tiffimage_int.cpp 89.28% <ø> (ø)
src/sonymn_int.cpp 69.31% <100.00%> (+0.32%) ⬆️
src/image.cpp 72.68% <0.00%> (-0.07%) ⬇️
src/canonmn_int.cpp 74.92% <0.00%> (ø)
src/tiffvisitor_int.cpp 87.53% <0.00%> (+0.01%) ⬆️
src/jpgimage.cpp 86.62% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a85d9...6ef38ed. Read the comment docs.

SonySInfo1 is currently supported by all Sony cameras so does not need
to test for unsupported models.
@postscript-dev postscript-dev changed the title WIP: Add SonySInfo1 makernote tags (tag 3000) Add SonySInfo1 makernote tags (tag 3000) Jul 29, 2021
@hassec hassec added enhancement feature / functionality enhancements makerNote Anything related to one of the various supported MakerNote formats labels Jul 30, 2021
@hassec hassec merged commit 2b13148 into Exiv2:main Jul 30, 2021
@postscript-dev postscript-dev deleted the add_SonySInfo1_makernote_tags branch October 20, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature / functionality enhancements makerNote Anything related to one of the various supported MakerNote formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants