Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL query to detect unsafe uses of std::vector::operator[] #1771

Merged

Conversation

kevinbackhouse
Copy link
Collaborator

This is the CodeQL query that I used to search for unsafe uses of std::vector::operator[] in #1769. This query will produce quite a few alerts to begin with, but they'll be fixed when #1769 is rebased onto main.

@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #1771 (a2854f3) into main (9284b58) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1771   +/-   ##
=======================================
  Coverage   67.36%   67.36%           
=======================================
  Files         151      151           
  Lines       20802    20802           
=======================================
  Hits        14013    14013           
  Misses       6789     6789           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9284b58...a2854f3. Read the comment docs.

Copy link
Member

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

modulo the fact that I still haven't had the time to learn more about CodeQL so can't really review that part. But the from the report it looks like it's working :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants