Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeql analysis #1747

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Codeql analysis #1747

merged 4 commits into from
Jun 28, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

@kevinbackhouse kevinbackhouse commented Jun 27, 2021

Code scanning was enabled on the old-master branch, but didn't get transferred to main. This pull request is a rebase of @clanmills's original commit onto main. I also added main to the list of branches to test.

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #1747 (f7bd17f) into main (fe83c73) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1747      +/-   ##
==========================================
+ Coverage   66.89%   66.94%   +0.04%     
==========================================
  Files         151      151              
  Lines       20754    20794      +40     
==========================================
+ Hits        13883    13920      +37     
- Misses       6871     6874       +3     
Impacted Files Coverage Δ
src/preview.cpp 57.46% <0.00%> (-0.29%) ⬇️
samples/Jzon.cpp 33.39% <0.00%> (-0.18%) ⬇️
src/webpimage.cpp 64.97% <0.00%> (-0.17%) ⬇️
src/pgfimage.cpp 55.93% <0.00%> (-0.11%) ⬇️
src/image.cpp 72.51% <0.00%> (-0.05%) ⬇️
src/http.cpp 0.00% <0.00%> (ø)
src/version.cpp 91.71% <0.00%> (ø)
src/jpgimage.cpp 77.66% <0.00%> (ø)
src/crwimage_int.hpp 84.37% <0.00%> (ø)
src/cr2header_int.hpp 50.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe83c73...f7bd17f. Read the comment docs.

Copy link
Member

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinbackhouse 👍

@hassec hassec merged commit 695d22c into Exiv2:main Jun 28, 2021
@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants