Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy: pass by value #1712

Merged
merged 1 commit into from
Jun 27, 2021
Merged

clang-tidy: pass by value #1712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/tiffcomposite_int.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,9 @@ namespace Exiv2 {
//! Search key for TIFF mapping structures.
struct TiffMappingInfo::Key {
//! Constructor
Key(const std::string& m, uint32_t e, IfdId g) : m_(m), e_(e), g_(g) {}
Key(std::string m, uint32_t e, IfdId g) : m_(std::move(m)), e_(e), g_(g)
{
}
Comment on lines +400 to +402
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Key(std::string m, uint32_t e, IfdId g) : m_(std::move(m)), e_(e), g_(g)
{
}
Key(std::string m, uint32_t e, IfdId g) : m_(std::move(m)), e_(e), g_(g){}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git clang-format is what sets it to this.

std::string m_; //!< Camera make
uint32_t e_; //!< Extended tag
IfdId g_; //!< %Group
Expand Down