Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: use override #1710

Merged
merged 1 commit into from
Jun 27, 2021
Merged

clang-tidy: use override #1710

merged 1 commit into from
Jun 27, 2021

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jun 10, 2021

Found with modernize-use-override

Signed-off-by: Rosen Penev rosenp@gmail.com

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #1710 (069c53d) into main (19000cd) will not change coverage.
The diff coverage is 97.22%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1710   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files         151      151           
  Lines       20761    20761           
=======================================
  Hits        13889    13889           
  Misses       6872     6872           
Impacted Files Coverage Δ
src/exiv2app.hpp 100.00% <ø> (ø)
src/makernote_int.hpp 91.66% <90.90%> (ø)
src/actions.hpp 100.00% <100.00%> (ø)
src/cr2header_int.hpp 50.00% <100.00%> (ø)
src/crwimage_int.hpp 84.37% <100.00%> (ø)
src/orfimage_int.hpp 100.00% <100.00%> (ø)
src/rw2image_int.hpp 100.00% <100.00%> (ø)
src/tiffcomposite_int.hpp 100.00% <100.00%> (ø)
src/tiffimage_int.hpp 85.71% <100.00%> (ø)
src/tiffvisitor_int.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19000cd...069c53d. Read the comment docs.

@neheb neheb force-pushed the o2 branch 3 times, most recently from 2fa59c1 to a31e207 Compare June 10, 2021 22:01
Found with modernize-use-override

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@hassec hassec merged commit 37fea97 into Exiv2:main Jun 27, 2021
@neheb neheb deleted the o2 branch June 27, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants