-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Setup github actions workflow to build tagged release and nightly pre-release #1676
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1676 +/- ##
=======================================
Coverage 66.89% 66.90%
=======================================
Files 151 151
Lines 20747 20781 +34
=======================================
+ Hits 13879 13903 +24
- Misses 6868 6878 +10
Continue to review full report at Codecov.
|
Great to see this PR! 💪 For sure, I'll be happy to help with the windows case. The idea to build the release-notes automatically is also very interesting. I just wonder if it could look back in the git history (between tag v1 and v2) or it would only work from the moment in which the new workflow is added into the I have made few comments in the PR. Let me know what would be the best way to collaborate. |
Thanks @piponazo
not sure, maybe as a one off we would have to do it manually/with a script first and then let it take it from there. Haven't looked to deep into this.
I'm not seeing any comments here yet... |
This is starting to look better 😃 Workflow now automatically creates the release and uploads the binaries to that release. see here for example Windows build is still only working without NLS. @piponazo do you think you could have a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice to see the creation of the releases automatically 👏
I want to give a try to the NLS stuff on windows, but I am not sure when I will have some spare time for that. Hopefully I can spend at least 1 hour in the next 2-3 days.
@piponazo from my side this is ready. 🚀 Final results look like this now. That is:
The nightly will hopefully make it easier for people to test the development version and provide feedback throughout the development cycle towards v1.0. NLS in Windows still isn't fixed, but IMHO we could merge as-is, to get the nightly build etc running and add the NLS as soon as we know how to fix it. WDYT? oh, and sidenote: fixing the ci's resulted in a lot of commits here 🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution!
The idea of the workflow right now is to simply build the required releases if a tag gets pushed to the repo.
Only a first draft to get some feedback.
You can see the result in my fork here
Being completely new to conan and also not having a windows machine to test, I'm still fighting to get the windows build to work.
Was hoping maybe @piponazo could take a quick look and see if you know an easy fix?
In any case, I think it's a nice idea to set it up this way, and we can add more to it, e.g.:
Let me know what you guys think: 👍 ? or 👎
I'm happy to put some more time into this, if people think it's the way we should go