Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: use dynamic cast #1670

Merged
merged 1 commit into from
May 20, 2021
Merged

clang-tidy: use dynamic cast #1670

merged 1 commit into from
May 20, 2021

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented May 19, 2021

Found with cppcoreguidelines-pro-type-static-cast-downcast

Signed-off-by: Rosen Penev rosenp@gmail.com

Found with cppcoreguidelines-pro-type-static-cast-downcast

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1670 (7ed2c46) into main (8dbc699) will decrease coverage by 0.01%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1670      +/-   ##
==========================================
- Coverage   66.89%   66.88%   -0.02%     
==========================================
  Files         151      151              
  Lines       20747    20743       -4     
==========================================
- Hits        13879    13874       -5     
- Misses       6868     6869       +1     
Impacted Files Coverage Δ
samples/Jzon.cpp 33.44% <0.00%> (-0.63%) ⬇️
samples/exiv2json.cpp 75.60% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbc699...7ed2c46. Read the comment docs.

@neheb neheb merged commit 7179300 into Exiv2:main May 20, 2021
@neheb neheb deleted the dy branch May 20, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants