Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default con/destructors in headers #1667

Merged
merged 1 commit into from
May 20, 2021
Merged

default con/destructors in headers #1667

merged 1 commit into from
May 20, 2021

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented May 19, 2021

Signed-off-by: Rosen Penev rosenp@gmail.com

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1667 (c3c395e) into main (8dbc699) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1667   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files         151      151           
  Lines       20747    20748    +1     
=======================================
+ Hits        13879    13880    +1     
  Misses       6868     6868           
Impacted Files Coverage Δ
src/error.cpp 89.74% <ø> (ø)
include/exiv2/error.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbc699...c3c395e. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2021

This pull request introduces 1 alert and fixes 1 when merging c3c395e into 8dbc699 - view on LGTM.com

new alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@neheb neheb merged commit e5894d7 into Exiv2:main May 20, 2021
@neheb neheb deleted the err branch May 20, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants