Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual for range conversions #1653

Merged
merged 1 commit into from
May 17, 2021
Merged

manual for range conversions #1653

merged 1 commit into from
May 17, 2021

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented May 15, 2021

No description provided.

@neheb neheb force-pushed the forr branch 3 times, most recently from 898fee0 to 721f074 Compare May 15, 2021 22:31
@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #1653 (83f308c) into main (8e52032) will decrease coverage by 0.03%.
The diff coverage is 82.88%.

❗ Current head 83f308c differs from pull request most recent head 4489505. Consider uploading reports for the commit 4489505 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1653      +/-   ##
==========================================
- Coverage   66.94%   66.90%   -0.04%     
==========================================
  Files         151      151              
  Lines       20787    20787              
==========================================
- Hits        13915    13907       -8     
- Misses       6872     6880       +8     
Impacted Files Coverage Δ
src/olympusmn_int.cpp 20.46% <20.00%> (-0.54%) ⬇️
src/actions.cpp 72.52% <85.71%> (ø)
src/tiffcomposite_int.cpp 82.14% <91.66%> (-0.06%) ⬇️
src/crwimage_int.cpp 87.20% <94.73%> (-0.11%) ⬇️
src/tiffvisitor_int.cpp 87.34% <94.73%> (-0.06%) ⬇️
samples/exiv2json.cpp 75.75% <100.00%> (+0.14%) ⬆️
src/value.cpp 80.30% <100.00%> (ø)
samples/Jzon.cpp 34.05% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e52032...4489505. Read the comment docs.

@neheb neheb force-pushed the forr branch 4 times, most recently from e7a3bed to e788d15 Compare May 17, 2021 05:34
piponazo
piponazo previously approved these changes May 17, 2021
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@piponazo
Copy link
Collaborator

Ups. there are some conflicts. Could you please resolve them?

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
Copy link
Collaborator Author

neheb commented May 17, 2021

Rebased.

@piponazo piponazo merged commit 20dfab8 into Exiv2:main May 17, 2021
@neheb neheb deleted the forr branch May 17, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants