Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation with EXIV2_DEBUG_MESSAGES #1644

Merged
merged 1 commit into from
May 14, 2021
Merged

fix compilation with EXIV2_DEBUG_MESSAGES #1644

merged 1 commit into from
May 14, 2021

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented May 14, 2021

Signed-off-by: Rosen Penev rosenp@gmail.com

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1644 (e961f82) into main (44eb561) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1644   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files         151      151           
  Lines       20808    20808           
=======================================
  Hits        13922    13922           
  Misses       6886     6886           
Impacted Files Coverage Δ
src/cr2image.cpp 9.21% <ø> (ø)
src/exif.cpp 76.26% <ø> (ø)
src/orfimage.cpp 47.43% <ø> (ø)
src/rw2image.cpp 46.51% <ø> (ø)
src/tiffimage.cpp 84.74% <ø> (ø)
src/xmp.cpp 89.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44eb561...e961f82. Read the comment docs.

@piponazo
Copy link
Collaborator

I will create a new CI build to enable all the possible CMake options, so that we detect this issues sooner

@piponazo piponazo merged commit bf290e8 into Exiv2:main May 14, 2021
@piponazo piponazo mentioned this pull request May 14, 2021
@neheb neheb deleted the debug branch May 14, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants