Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default con/destructors in headers #1629

Merged
merged 1 commit into from
May 12, 2021
Merged

default con/destructors in headers #1629

merged 1 commit into from
May 12, 2021

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented May 12, 2021

Helps to optimize trivially destructable stuff.

Signed-off-by: Rosen Penev rosenp@gmail.com

Helps to optimize trivially destructable stuff.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
Copy link
Collaborator Author

neheb commented May 12, 2021

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2021

This pull request introduces 1 alert and fixes 1 when merging 3aec8aa into 8337462 - view on LGTM.com

new alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@piponazo piponazo merged commit 2e73aa9 into Exiv2:main May 12, 2021
@neheb neheb deleted the defaultc branch May 12, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants