-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving all CI jobs to GitHub #1626
Conversation
4c2c171
to
4e7e13e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1626 +/- ##
=======================================
Coverage ? 66.91%
=======================================
Files ? 151
Lines ? 20808
Branches ? 0
=======================================
Hits ? 13924
Misses ? 6884
Partials ? 0 Continue to review full report at Codecov.
|
3293bc7
to
d755fee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @piponazo! This looks great 🎉
Proposed configuration makes sense to me.
2 cents I'd like to add:
- we should keep an eye out if we ever observe that we see problems in the nightly that we don't pick up on the PR CIs. In that case those should be added to the PR ones as well.
- I think the nightly CI would actually be a good possibility for us to create a nightly release of the library... no? 🤔 Definitely not for this PR but maybe for our todo list
Configuration looks great to me, but I'm still not an expert with GH actions, so this is mostly based on the fact that they all seem to run fine 😆
Approving and passing back to you for merge 👍
Sure, I decided to move them from "on: push_request" to nightly to speed up the CI loop feedback but we definitely need to keep an eye on it. In a future PR, I want to cleanup some documentation about the CI stuff and also try to show the CI status in the main README.md.
I also thought about it :). I was thinking about creating releases when using the "Releases and PreReleases" options in Github or also when creating tags. I need to play a bit with it, but I will probably do it in a different PR (this one is already too big). The last commits in this branch are about using the cache feature to cache the conan packages. So you might see some rebases and re-write of the git history while I try some things out 😉 |
a00242a
to
8815a57
Compare
a93ba0e
to
2f9910b
Compare
The objective os this PR is to move all the existing jobs we have in different CI platforms (Travis, AppVeyor, Gitlab) to a single place (Github actions).
Also, in order to speed up things on CI, I am thinking about better strategies to trigger different jobs. At the moment this is what I have in mind: