Move include/CMake content to src #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time I wanted to modify the CMake code which is taking care of the installation of the public headers.
We keep all the public headers in the directory
include/exiv2and in the past somebody added a fileinclude/exiv2/CMakeLists.txtto manage the installation of these files.We have another CMake file
src/CMakeLists.txtwhich is the one taking care of the configuration of the library and main terminal application (source files, dependencies, installation, etc).I find more natural to remove the file
include/exiv2/CMakeLists.txtand include its content intosrc/CMakeLists.txt. Even though the public headers are in a different directory, they are considered a intrinsic part of the library.